Skip to contentSkip to conversation

Please revert commit fa0115c3c06176bd0fdfcd8966021979ec84f3d7

DISCUSSION Seewer Philippe 1 participant 2 messages Jun 23, 2009 – Jun 24, 2009 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Commit fa0115c3c06176bd0fdfcd8966021979ec84f3d7 moved calling
cryptsetup from the mount hook to inside a udev rule. While this is a good idea it causes more problems than it solves:

cryptsetup version 1.6 (and possibly earlier versions) calls 'udevadm settle' on it's own. This must not be done from inside udev rules as it potentially results in a deadlock depending on udev version.

Thank you,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 7 lines · Seewer Philippe

Commit fa0115c3c06176bd0fdfcd8966021979ec84f3d7 moved calling
cryptsetup from the mount hook to inside a udev rule. While this is a good idea it causes more problems than it solves:

cryptsetup version 1.6 (and possibly earlier versions) calls 'udevadm settle' on it's own. This must not be done from inside udev rules as it potentially results in a deadlock depending on udev version.

A short amendment to this:

- Fedora cryptsetup is patched, removing the udevadm settle altogether. That's why it was working for most of you. (Thanks to Warren for helping to debug this)

- In addition I don't think its a good idea to include anything in a udev-rule that does user interaction, since udev has an built-in event-timeout.

Quoted 7 lines

Thank you,
Philippe

Signature · 3 lines
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html