Skip to contentSkip to conversation

drm: Fixes error with gcc 3.3.5 in i915 driver.

PATCH New Torsten Hilbrich 1 participant 1 message Jun 23, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Fixes error with gcc 3.3.5 in i915 driver.

When compiling with gcc 3.3.5 I got the following error message in the module i915.ko:

ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!

This error did not occur when compiling the same code in gcc 4.3.2.

This patch replaces the 64 bit division by a call of div_u64 to avoid triggering the problem on the older compiler.

The code to be fixed was introduced in
commit 2c07245fb8f7f0a282282e5a9747e46defdb2cc7

---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_display.c
index 3e1c781..306d198 100644

drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -1502,7 +1502,7 @@ igdng_compute_m_n(int bytes_per_pixel, int nlanes,
 
 	temp = (u64) DATA_N * pixel_clock;
 	temp = div_u64(temp, link_clock);
-	m_n->gmch_m = (temp * bytes_per_pixel) / nlanes;
+	m_n->gmch_m = div_u64(temp * byte_per_pixel, nlanes);
 	m_n->gmch_n = DATA_N;
 	fdi_reduce_ratio(&m_n->gmch_m, &m_n->gmch_n);
 
Signature · 1 line
1.5.4.2