tcp: missing check ACK flag of received segment in FIN-WAIT-2 state
Subsystems (3)
PATCH 1/1 tcp: missing check ACK flag of received segment in FIN-WAIT-2 state
RFC0793 defined that in FIN-WAIT-2 state if the ACK bit is off drop the segment and return[Page 72]. But this check is missing in function tcp_timewait_state_process(). This cause the segment with FIN flag but no ACK has two diffent action:
Case 1:
Node A Node B
<------------- FIN,ACK
(enter FIN-WAIT-1)
ACK ------------->
(enter FIN-WAIT-2)
FIN -------------> discard
(move sk to tw list)Case 2:
Node A Node B
<------------- FIN,ACK
(enter FIN-WAIT-1)
ACK ------------->
(enter FIN-WAIT-2)
(move sk to tw list)
FIN ------------->
<------------- ACKThis patch fixed the problem.
Signed-off-by Wei Yongjun <[email protected]>
--- net/ipv4/tcp_minisocks.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
net/ipv4/tcp_minisocks.c +2 -1
@@ -128,7 +128,8 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, goto kill_with_rst;/* Dup ACK? */ -if (!after (TCP_SKB_CB (skb)->end_seq, tcptw->tw_rcv_nxt) || +if (!th->ack || + !after (TCP_SKB_CB (skb)->end_seq, tcptw->tw_rcv_nxt) ||TCP_SKB_CB (skb)->end_seq ==TCP_SKB_CB (skb)->seq) {inet_twsk_put (tw);return TCP_TW_SUCCESS ;
Signature · 1 line
1.6.2.2
David Miller
maintainerFrom: Wei Yongjun <[email protected]>
Date: Thu, 25 Jun 2009 16:29:31 +0800
Quoted 4 lines
RFC0793 defined that in FIN-WAIT-2 state if the ACK bit is off drop the segment and return[Page 72]. But this check is missing in function
tcp_timewait_state_process(). This cause the segment with FIN flag but no ACK has two diffent action:
...
Quoted 3 lines
This patch fixed the problem.
Signed-off-by Wei Yongjun <[email protected]>
Patch applied, thank you.