Skip to contentSkip to conversation

linux-next: xfs tree build failure

PATCH In review Stephen Rothwell 3 participants 3 messages Jul 3, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi David,

Today's linux-next build (x86_64 allmodconfig) failed like this:

fs/xfs/xfs_log_recover.c: In function 'xlog_recover_check_summary':
fs/xfs/xfs_log_recover.c:4046: error: implicit declaration of function 'xfs_read_agf'

Caused by commit 370f048214b4e9aa2102fa3c454ae1374da287c5 ("xfs: add more statics & drop some unused functions").

I have used the xfs tree from next-20090702 for today.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw

PATCH 1/1 un-static xfs_read_agf

CONFIG_XFS_DEBUG builds still need xfs_read_agf to be non-static, oops.

---

fs/xfs/xfs_ag.h +3 -0
Index: linux-2.6/fs/xfs/xfs_ag.h
===================================================================
@@ -91,6 +91,9 @@ typedef struct xfs_agf {
 #define	XFS_AGF_BLOCK(mp)	XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))
 #define	XFS_BUF_TO_AGF(bp)	((xfs_agf_t *)XFS_BUF_PTR(bp))
 
+extern int xfs_read_agf(struct xfs_mount *mp, struct xfs_trans *tp,
+			xfs_agnumber_t agno, int flags, struct xfs_buf **bpp);
+
 /*
  * Size of the unlinked inode hash table in the agi.
  */
fs/xfs/xfs_alloc.c +1 -1
Index: linux-2.6/fs/xfs/xfs_alloc.c
===================================================================
@@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(
 /*
  * Read in the allocation group header (free/alloc section).
  */
-STATIC int				/* error */
+int					/* error */
 xfs_read_agf(
 	struct xfs_mount	*mp,	/* mount point structure */
 	struct xfs_trans	*tp,	/* transaction pointer */
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH] un-static xfs_read_agf

Quoted 4 lines · Eric Sandeen

CONFIG_XFS_DEBUG builds still need xfs_read_agf to be non-static, oops.

Quoted 31 lines

---

Index: linux-2.6/fs/xfs/xfs_ag.h
===================================================================

fs/xfs/xfs_ag.h +3 -0
@@ -91,6 +91,9 @@ typedef struct xfs_agf {
 #define	XFS_AGF_BLOCK(mp)	XFS_HDR_BLOCK(mp, XFS_AGF_DADDR(mp))
 #define	XFS_BUF_TO_AGF(bp)	((xfs_agf_t *)XFS_BUF_PTR(bp))
 
+extern int xfs_read_agf(struct xfs_mount *mp, struct xfs_trans *tp,
+			xfs_agnumber_t agno, int flags, struct xfs_buf **bpp);
+
 /*
 * Size of the unlinked inode hash table in the agi.
 */

Index: linux-2.6/fs/xfs/xfs_alloc.c
===================================================================

fs/xfs/xfs_alloc.c +1 -1
@@ -2248,7 +2248,7 @@ xfs_alloc_put_freelist(
 /*
 * Read in the allocation group header (free/alloc section).
 */
-STATIC int				/* error */
+int					/* error */

xfs_read_agf(
struct xfs_mount *mp, /* mount point structure */
struct xfs_trans *tp, /* transaction pointer */