pre_command chaining
RFC 1/1 pre_command chaining
Hi,
the way how kvm_autotest currently handle pre_command/post_command it don't allow to specify more than one command. BASH can handle this itself with a small change in the framework , as shown in the attachment.
In .cfg file we just change variable from:
pre_command = "command"
to:
pre_commane += "command &&"
produce:
$(command && true)
Framework adds the last command true, which enclose whole command. This way we can chain infinite pre/post_commands without losing the return value (if something go wrong, other commands are not executed and return value is preserve.
example:
in cfg:
pre_command += "echo A &&"
pre_command += "echo B &&"
pre_command += "echo C &&"
framework params.get("pre_command"):
"echo A && echo B && echo C &&"
framework process_command execute on the host:
"echo A && echo B && echo C && true"
regards,
Lukáš Doktor
client/tests/kvm/kvm_preprocessing.py +4 -2
@@ -229,7 +229,8 @@ def preprocess(test, params, env): #execute any pre_commands if params.get("pre_command"): - process_command(test, params, env, params.get("pre_command"), + process_command(test, params, env, + (params.get("pre_command") + " true"), params.get("pre_command_timeout"), params.get("pre_command_noncritical"))
@@ -287,7 +288,8 @@ def postprocess(test, params, env): #execute any post_commands if params.get("post_command"): - process_command(test, params, env, params.get("post_command"), + process_command(test, params, env, + (params.get("post_command") + " true"), params.get("post_command_timeout"), params.get("post_command_noncritical"))