ubi: help message correction
PATCH 1/1 ubi: help message correction
Fix incorrect information about size units.
---
common/cmd_ubi.c +1 -1
@@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi," - Remove volume\n" "[Legends]\n" " volume: charater name\n" -" size: KiB, MiB, GiB, and bytes\n" +" size: hex value\n" " type: s[tatic] or d[ynamic] (default=dynamic)" );
PATCH 1/1 ubi: help message correction
Dear Andrzej Wolski,
Quoted 9 lines · In message <[email protected]> you wrote:
Fix incorrect information about size units.
Signed-off-by Andrzej Wolski <[email protected]>---
common/cmd_ubi.c +0
-0
common/cmd_ubi.c U_BOOT_CMD(ubi, 6, 1, do_ubi, · line 613
Quoted 7 lines
common/cmd_ubi.c +1
-1@@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi," - Remove volume\n" "[Legends]\n" " volume: charater name\n" -" size: KiB, MiB, GiB, and bytes\n" +" size: hex value\n" " type: s[tatic] or d[ynamic] (default=dynamic)" );
This is IMHO not a helpful help message.
First, it is reduncant, as all input in U-Boot is in hex format. So why repeat that information. And "size: value" - what does that tell me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB, bytes, blocks, or whatever?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "We don't have to protect the environment -- the Second Coming is at hand." - James Watt
PATCH 1/1 ubi: help message correction
Quoted 20 lines
Quoted 9 lines · In message <[email protected]> you wrote:
Fix incorrect information about size units.
Signed-off-by Andrzej Wolski <[email protected]>---
common/cmd_ubi.c +0
-0common/cmd_ubi.c U_BOOT_CMD(ubi, 6, 1, do_ubi, · line 613
Quoted 7 lines
common/cmd_ubi.c +1
-1@@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi," - Remove volume\n" "[Legends]\n" " volume: charater name\n" -" size: KiB, MiB, GiB, and bytes\n" +" size: hex value\n" " type: s[tatic] or d[ynamic] (default=dynamic)" );This is IMHO not a helpful help message.
Quoted 4 lines
First, it is reduncant, as all input in U-Boot is in hex format. So why repeat that information. And "size: value" - what does that tell me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB, bytes, blocks, or whatever?
This is size in bytes. Original message was probably based on Linux mtd-utils where size in KiB, MiB, etc. can be specified. This is not true in U-Boot where all input is in hex, so this message have to be corrected. If you think "hex value" is not helpful, can you suggest something better? Maybe just remove size entry?
Regards,
Andrzej Wolski
PATCH 1/1 ubi: help message correction
Hi Andrzej,
Quoted 25 lines
Quoted 20 lines
Quoted 9 lines · In message <[email protected]> you wrote:
Fix incorrect information about size units.
Signed-off-by Andrzej Wolski <[email protected]>---
common/cmd_ubi.c +0
-0common/cmd_ubi.c U_BOOT_CMD(ubi, 6, 1, do_ubi, · line 613
Quoted 7 lines
common/cmd_ubi.c +1
-1@@ -608,6 +608,6 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi," - Remove volume\n" "[Legends]\n" " volume: charater name\n" -" size: KiB, MiB, GiB, and bytes\n" +" size: hex value\n" " type: s[tatic] or d[ynamic] (default=dynamic)" );This is IMHO not a helpful help message.
Quoted 4 lines
First, it is reduncant, as all input in U-Boot is in hex format. So why repeat that information. And "size: value" - what does that tell me? Would it not be good to mention the unit? Is it in KiB, MiB, GiB, bytes, blocks, or whatever?
Quoted 5 lines
This is size in bytes. Original message was probably based on Linux mtd-utils where size in KiB, MiB, etc. can be specified. This is not true in U-Boot where all input is in hex, so this message have to be corrected. If you think "hex value" is not helpful, can you suggest something better? Maybe just remove size entry?
How about "size: specified in bytes"?
Cheers
Detlev
Signature · 6 lines
I talk to planets baby
-- Dave Wyndorf (Monstermagnet)
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.dePATCH 1/1 ubi: help message correction
Fix incorrect information about size units and correct typo.
---
common/cmd_ubi.c +2 -2
@@ -618,7 +618,7 @@ U_BOOT_CMD(ubi, 6, 1, do_ubi,"ubi remove[vol] volume" " - Remove volume\n" "[Legends]\n" -" volume: charater name\n" -" size: KiB, MiB, GiB, and bytes\n" +" volume: character name\n" +" size: specified in bytes\n" " type: s[tatic] or d[ynamic] (default=dynamic)" );
----------------------------------------------------------------------
Bezp?atne konto? Otw?rz tutaj!
Quoted 1 line
Quoted 1 line
PATCH 1/1 ubi: help message correction
Quoted 3 lines · On Friday 17 July 2009 22:26:54 Andrzej Wolski wrote:
Fix incorrect information about size units and correct typo.
Signed-off-by Andrzej Wolski <[email protected]>
Patch didn't apply clean. I fixed this manually. So, applied to u-boot-ubi.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================