Skip to contentSkip to conversation

Add mac resource support for w90p910

PATCH In review Wan ZongShun 2 participants 4 messages Jul 16, 2009 – Jul 17, 2009

Subsystems (4)
Networking Network drivers Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Wan ZongShun

author
#0 lore raw

PATCH 1/1 Add mac resource support for w90p910

Dear Russell,

This is a mac resource define for my MAC driver for w90p910 platform.

thanks!

Add mac resource support for w90p910 mac driver

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/mach-w90p910evb.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
arch/arm/mach-w90x900/mach-w90p910evb.c +28 -0
index 7a62bd3..06e1155 100644
@@ -228,6 +228,33 @@ struct platform_device w90x900_device_usbgadget = {
 };
 EXPORT_SYMBOL(w90x900_device_usbgadget);
 
+/* EMC Device */
+
+static struct resource w90x900_emc_resource[] = {
+	[0] = {
+		.start = W90X900_PA_EMC,
+		.end   = W90X900_PA_EMC + W90X900_SZ_EMC - 1,
+		.flags = IORESOURCE_MEM,
+	},
+	[1] = {
+		.start = IRQ_EMCTX,
+		.end   = IRQ_EMCTX,
+		.flags = IORESOURCE_IRQ,
+	},
+	[2] = {
+		.start = IRQ_EMCRX,
+		.end   = IRQ_EMCRX,
+		.flags = IORESOURCE_IRQ,
+	}
+};
+
+struct platform_device w90p910_device_emc = {
+	.name		= "w90p910-emc",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(w90x900_emc_resource),
+	.resource	= w90x900_emc_resource,
+};
+
 static struct map_desc w90p910_iodesc[] __initdata = {
 };
 

@@ -242,6 +269,7 @@ static struct platform_device *w90p910evb_dev[] __initdata = {
 	&w90x900_device_rtc,
 	&w90x900_device_kpi,
 	&w90x900_device_usbgadget,
+	&w90p910_device_emc,
 };
 
 static void __init w90p910evb_map_io(void)
Signature · 1 line
1.5.6.3
#1 lore raw

Hi Wan,

Review

Quoted 2 lines · Wan ZongShun
(quoted diff) +2 -0
+
+struct platform_device w90p910_device_emc = {

static?

Signature · 3 lines
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
author
#2 lore raw

Dear Trilok,

Thanks for your reviewing, I fixed up and resubmitted this patch.

patch text:

Add mac resource support for w90p910 mac driver

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/mach-w90p910evb.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
arch/arm/mach-w90x900/mach-w90p910evb.c +28 -0
index 7a62bd3..3becabb 100644
@@ -228,6 +228,33 @@ struct platform_device w90x900_device_usbgadget = {
 };
 EXPORT_SYMBOL(w90x900_device_usbgadget);
 
+/* USB mac device */
+
+static struct resource w90x900_emc_resource[] = {
+	[0] = {
+		.start = W90X900_PA_EMC,
+		.end   = W90X900_PA_EMC + W90X900_SZ_EMC - 1,
+		.flags = IORESOURCE_MEM,
+	},
+	[1] = {
+		.start = IRQ_EMCTX,
+		.end   = IRQ_EMCTX,
+		.flags = IORESOURCE_IRQ,
+	},
+	[2] = {
+		.start = IRQ_EMCRX,
+		.end   = IRQ_EMCRX,
+		.flags = IORESOURCE_IRQ,
+	}
+};
+
+static struct platform_device w90p910_device_emc = {
+	.name		= "w90p910-emc",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(w90x900_emc_resource),
+	.resource	= w90x900_emc_resource,
+};
+
 static struct map_desc w90p910_iodesc[] __initdata = {
 };
 

@@ -242,6 +269,7 @@ static struct platform_device *w90p910evb_dev[] __initdata = {
 	&w90x900_device_rtc,
 	&w90x900_device_kpi,
 	&w90x900_device_usbgadget,
+	&w90p910_device_emc,
 };
 
 static void __init w90p910evb_map_io(void)
Signature · 1 line
1.5.6.3
Quoted 8 lines

Hi Wan,

Review

Quoted 2 lines · Wan ZongShun
(quoted diff) +2 -0
+
+struct platform_device w90p910_device_emc = {

static?

Reviewed-by
#3 lore raw

Hi Wan,

Quoted 4 lines · Wan ZongShun

Dear Trilok,

Thanks for your reviewing, I fixed up and resubmitted this patch.

Quoted 8 lines

patch text:

Add mac resource support for w90p910 mac driver

Signed-off-by Wan ZongShun <[email protected]>

---
 arch/arm/mach-w90x900/mach-w90p910evb.c |   28 ++++++++++++++++++++++++++++

 1 files changed, 28 insertions(+), 0 deletions(-)

Looks good:

Reviewed-by Trilok Soni <[email protected]>
Signature · 3 lines
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni