Makefile: suppress error message from shell
Subsystems (2)
PATCH 3/5 Makefile: suppress error message from shell
In particular, on systems which do not have 'pkg-config' installed, every invocation of make issues the following message:
/bin/sh: pkg-config: command not found
Suppress the message by redirecting stderr to the bit-bucket.
--- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
@@ -15,7 +15,7 @@ AR = ar # CFLAGS += -O0 -DDEBUG -g3 -gdwarf-2 # -HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 && echo 'yes') +HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 2>/dev/null && echo 'yes') HAVE_GCC_DEP=$(shell touch .gcc-test.c && \ $(CC) -c -Wp,-MD,.gcc-test.d .gcc-test.c 2>/dev/null && \ echo 'yes'; rm -f .gcc-test.d .gcc-test.o .gcc-test.c)
Signature · 1 line
1.6.3.1
Quoted 6 lines · Ramsay Jones
In particular, on systems which do not have 'pkg-config' installed, every invocation of make issues the following message:
/bin/sh: pkg-config: command not foundSuppress the message by redirecting stderr to the bit-bucket.
[...]
Makefile AR = ar · line 18
Quoted 8 lines
Makefile +1
-1@@ -15,7 +15,7 @@ AR = ar # CFLAGS += -O0 -DDEBUG -g3 -gdwarf-2 # -HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 && echo 'yes') +HAVE_LIBXML=$(shell pkg-config --exists libxml-2.0 2>/dev/null && echo 'yes')
Seems sensible; this way, systems without pkg-config will simply end up without HAVE_LIBXML.
- Josh Triplett
Quoted 7 lines · Ramsay Jones
Quoted 6 lines
In particular, on systems which do not have 'pkg-config' installed, every invocation of make issues the following message:
/bin/sh: pkg-config: command not foundSuppress the message by redirecting stderr to the bit-bucket.
Applied.
Thanks
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Christopher Li
Quoted 7 lines · Ramsay Jones
Quoted 6 lines
In particular, on systems which do not have 'pkg-config' installed, every invocation of make issues the following message:
/bin/sh: pkg-config: command not foundSuppress the message by redirecting stderr to the bit-bucket.
Applied.
Thanks
Thanks.
Hmm, I noticed that you edited the "subject line" when you applied the patch; namely s/shell/pkg-config/.
I find this a little puzzling, since the error message *is* issued by the shell and is definitely *not* issued by pkg-config... which is kinda the point... ;-)
ATB,
Ramsay Jones
Christopher Li
maintainerQuoted 7 lines · Ramsay Jones
Hmm, I noticed that you edited the "subject line" when you applied the patch; namely s/shell/pkg-config/.
I find this a little puzzling, since the error message *is* issued by the shell and is definitely *not* issued by pkg-config... which is kinda the point... ;-)
Oh, right. The error is issue from shell when it try to run pkg-config. If I just read the title, it is hard for me to predict where the change is going to be. I just want to be more specific.
There is a reason I haven't push those to official tree yet. We can still change it if we want. Suggestion?
Chris
Quoted 8 lines · Christopher Li
Quoted 7 lines · Ramsay Jones
Hmm, I noticed that you edited the "subject line" when you applied the patch; namely s/shell/pkg-config/.
I find this a little puzzling, since the error message *is* issued by the shell and is definitely *not* issued by pkg-config... which is kinda the point... ;-)
Quoted 6 lines
Oh, right. The error is issue from shell when it try to run pkg-config. If I just read the title, it is hard for me to predict where the change is going to be. I just want to be more specific.
There is a reason I haven't push those to official tree yet. We can still change it if we want. Suggestion?
I liked the original myself. :)
The "Makefile:" prefix was intended to indicate where the change was made and I thought that the one-line summary was compact and accurate.
It's a bit difficult to indicate that "the cause of the error, which is issued by the shell, is a missing pkg-config command on some systems" as part of the one-line summary. (So I didn't try ;P )
Having said that, I can't claim to be good at writing commit messages. So, feel free to re-write it as you wish.
ATB,
Ramsay Jones