Skip to contentSkip to conversation

Only build iptables-xml when shared libraries are enabled

PATCH In review Philip Craig 2 participants 2 messages Jul 20, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Only build iptables-xml when shared libraries are enabled

Only build iptables-xml when shared libraries are enabled

There is no static version of iptables-xml currently. I'm building for a target that has no libdl.

Makefile.am +2 -1
index a9e3ad3..657ef41 100644
@@ -81,7 +81,7 @@ ip6tables_static_SOURCES    = ${ip6tables_multi_SOURCES} xtables.c
 ip6tables_static_CFLAGS     = ${ip6tables_multi_CFLAGS} -DNO_SHARED_LIBS=1
 ip6tables_static_LDADD      = libiptc/libip6tc.la extensions/libext6.a -lm
 
-bin_PROGRAMS     = iptables-xml
+bin_PROGRAMS     =
 sbin_PROGRAMS    =
 noinst_PROGRAMS  =
 man_MANS         = iptables.8 iptables-restore.8 iptables-save.8 \
@@ -98,6 +98,7 @@ sbin_PROGRAMS += ip6tables-static
 endif
 endif
 if ENABLE_SHARED
+bin_PROGRAMS  += iptables-xml
 if ENABLE_IPV4
 sbin_PROGRAMS += iptables iptables-multi iptables-restore iptables-save
 endif
#1 lore raw
Quoted 6 lines · Philip Craig

Only build iptables-xml when shared libraries are enabled

There is no static version of iptables-xml currently.

Naah:
-rwxr-xr-x 1 jengelh users 209336 Jul 16 19:41 iptables-xml

(look at the size, it has obviously been compiled with ./configure --disable-shared)

Quoted 10 lines

I'm building for a target that has no libdl.

(quoted diff) +0 -0
@@ -81,7 +81,7 @@ ip6tables_static_SOURCES    = ${ip6tables_multi_SOURCES} xtables.c

ip6tables_static_CFLAGS = ${ip6tables_multi_CFLAGS} -DNO_SHARED_LIBS=1
ip6tables_static_LDADD = libiptc/libip6tc.la extensions/libext6.a -lm

Makefile.am +1 -1
-bin_PROGRAMS     = iptables-xml
+bin_PROGRAMS     =
sbin_PROGRAMS    =
noinst_PROGRAMS  =
man_MANS         = iptables.8 iptables-restore.8 iptables-save.8 \

Since there is no mention of -ldl for grep iptables.xml Makefile.am (instead we need to change something else), I declare this patch not applicable.

Static, as far as iptables is concerned, only means that extensions are built-in. It still uses libc and so on. Maybe should rename that to avoid confusion..