Skip to contentSkip to conversation

xpedite5200, 5370: Use buffered NOR flash writes

PATCH New ptyser at xes-inc.com 4 participants 7 messages Jul 20, 2009 – Jul 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 xpedite5200, 5370: Use buffered NOR flash writes

From: Peter Tyser <[email protected]>

Buffered writes are possible on the XPedite5200 and XPedite5370 and greatly improve NOR flash write speeds

---
I miscalculated the merge window close time... I hope to slip these last 3 trivial changes in the upcoming release if possible.

Thanks,
Peter

 include/configs/XPEDITE5200.h |    1 +
 include/configs/XPEDITE5370.h |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
include/configs/XPEDITE5200.h +1 -0
index 89ab692..617f514 100644
@@ -129,6 +129,7 @@
 #define CONFIG_SYS_FLASH_WRITE_TOUT	500		/* Flash Write Timeout (ms) */
 #define CONFIG_FLASH_CFI_DRIVER
 #define CONFIG_SYS_FLASH_CFI
+#define CONFIG_SYS_FLASH_USE_BUFFER_WRITE
 #define CONFIG_SYS_FLASH_AUTOPROTECT_LIST	{ {0xfff40000, 0xc0000}, \
 						  {0xfbf40000, 0xc0000} }
 #define CONFIG_SYS_MONITOR_BASE	TEXT_BASE	/* start of monitor */
include/configs/XPEDITE5370.h +1 -0
index 536e063..d00448b 100644
@@ -137,6 +137,7 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy);
 #define CONFIG_SYS_FLASH_WRITE_TOUT	500		/* Flash Write Timeout (ms) */
 #define CONFIG_FLASH_CFI_DRIVER
 #define CONFIG_SYS_FLASH_CFI
+#define CONFIG_SYS_FLASH_USE_BUFFER_WRITE
 #define CONFIG_SYS_FLASH_AUTOPROTECT_LIST	{ {0xfff40000, 0xc0000}, \
 						  {0xf7f40000, 0xc0000} }
 #define CONFIG_SYS_MONITOR_BASE	TEXT_BASE	/* start of monitor */
Signature · 1 line
1.6.2-rc2.GIT
#1 lore raw

PATCH 2/3 xpedite5370: Fix I2C GPIO initialization typo

From: Peter Tyser <[email protected]>

---
 board/xes/xpedite5370/xpedite5370.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
board/xes/xpedite5370/xpedite5370.c +2 -2
index 22cf294..d54c699 100644
@@ -84,8 +84,8 @@ int board_early_init_r(void)
 	/* Initialize PCA9557 devices */
 	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
 	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR1, 0xff, 0);
-	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
-	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
+	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR2, 0xff, 0);
+	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR3, 0xff, 0);
 
 	/*
 	 * Remap NOR flash region to caching-inhibited
Signature · 1 line
1.6.2-rc2.GIT
#2 lore raw

PATCH 3/3 Remove last remanants of unused CONFIG_I2C_CMD_TREE

From: Peter Tyser <[email protected]>

---
 include/configs/P2020DS.h     |    1 -
 include/configs/XPEDITE5170.h |    1 -
 include/configs/aria.h        |    1 -
 include/configs/mecp5123.h    |    1 -
 4 files changed, 0 insertions(+), 4 deletions(-)
include/configs/P2020DS.h +0 -1
index 676f013..70ab96f 100644
@@ -412,7 +412,6 @@ extern unsigned long calculate_board_ddr_clk(unsigned long dummy);
 #define CONFIG_HARD_I2C		/* I2C with hardware support */
 #undef	CONFIG_SOFT_I2C		/* I2C bit-banged */
 #define CONFIG_I2C_MULTI_BUS
-#define CONFIG_I2C_CMD_TREE
 #define CONFIG_SYS_I2C_SPEED		400000	/* I2C speed and slave address */
 #define CONFIG_SYS_I2C_EEPROM_ADDR	0x57
 #define CONFIG_SYS_I2C_SLAVE		0x7F
include/configs/XPEDITE5170.h +0 -1
index 2553293..985b589 100644
@@ -254,7 +254,6 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_SYS_I2C_OFFSET		0x3000
 #define CONFIG_SYS_I2C2_OFFSET		0x3100
 #define CONFIG_I2C_MULTI_BUS
-#define CONFIG_I2C_CMD_TREE
 
 /* PEX8518 slave I2C interface */
 #define CONFIG_SYS_I2C_PEX8518_ADDR	0x70
include/configs/aria.h +0 -1
index e7e238d..4211113 100644
@@ -376,7 +376,6 @@
 #define CONFIG_HARD_I2C			/* I2C with hardware support */
 #undef CONFIG_SOFT_I2C			/* so disable bit-banged I2C */
 #define CONFIG_I2C_MULTI_BUS
-#define CONFIG_I2C_CMD_TREE
 
 /* I2C speed and slave address */
 #define CONFIG_SYS_I2C_SPEED		100000
include/configs/mecp5123.h +0 -1
index e00859a..1ecae00 100644
@@ -249,7 +249,6 @@
 #define CONFIG_HARD_I2C			/* I2C with hardware support */
 #undef CONFIG_SOFT_I2C			/* so disable bit-banged I2C */
 #define CONFIG_I2C_MULTI_BUS
-#define CONFIG_I2C_CMD_TREE
 #define CONFIG_SYS_I2C_SPEED		400000	/* I2C speed */
 #define CONFIG_SYS_I2C_SLAVE		0x7F	/* slave address */
 
Signature · 1 line
1.6.2-rc2.GIT
#3 lore raw

PATCH 3/3 Remove last remanants of unused CONFIG_I2C_CMD_TREE

Hello Peter,

Quoted 9 lines · ptyser at xes-inc.com

From: Peter Tyser <[email protected]>

---
 include/configs/P2020DS.h     |    1 -
 include/configs/XPEDITE5170.h |    1 -
 include/configs/aria.h        |    1 -
 include/configs/mecp5123.h    |    1 -
 4 files changed, 0 insertions(+), 4 deletions(-)

added to u-boot-i2c.git
Thanks!

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#4 lore raw

PATCH 2/3 xpedite5370: Fix I2C GPIO initialization typo

In reply to ptyser at xes-inc.com

Hello Peter,

Quoted 12 lines · ptyser at xes-inc.com

From: Peter Tyser <[email protected]>

---
 board/xes/xpedite5370/xpedite5370.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
board/xes/xpedite5370/xpedite5370.c +0 -0
index 22cf294..d54c699 100644

board/xes/xpedite5370/xpedite5370.c int board_early_init_r(void) · line 91

Quoted 10 lines
board/xes/xpedite5370/xpedite5370.c +2 -2
@@ -84,8 +84,8 @@ int board_early_init_r(void)
 	/* Initialize PCA9557 devices */
 	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
 	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR1, 0xff, 0);
-	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
-	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR0, 0xff, 0);
+	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR2, 0xff, 0);
+	pca953x_set_pol(CONFIG_SYS_I2C_PCA953X_ADDR3, 0xff, 0);
 
 	/*
 	 * Remap NOR flash region to caching-inhibited

This go through the mpc85xx maintainer, so you get my

bye
Heiko

Applied
#6 lore raw

PATCH 1/3 xpedite5200, 5370: Use buffered NOR flash writes

In reply to ptyser at xes-inc.com
Quoted 6 lines · ptyser at xes-inc.com

From: Peter Tyser <[email protected]>

Buffered writes are possible on the XPedite5200 and XPedite5370 and greatly
improve NOR flash write speeds

Quoted 8 lines

---
I miscalculated the merge window close time... I hope to slip these last 3
trivial changes in the upcoming release if possible.

Thanks,
Peter

applied

- k