Skip to contentSkip to conversation

Add reboot fixup for SBC-fitPC2

PATCH In review Mike Rapoport 3 participants 4 messages Jul 20, 2009 – Jul 30, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add reboot fixup for SBC-fitPC2

Quoted 1 line

From: Denis Turischev <[email protected]>

This patch adds reboot fixup for CompuLab SBC-fitPC2 board.

diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c linux-2.6.31-rc3/arch/x86/kernel/reboot.c
--- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c 2009-07-14 04:18:52.000000000
+0300
+++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c 2009-07-16 14:39:48.000000000 +0300
@@ -249,6 +249,15 @@
DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
},
},
+ { /* Handle problems with rebooting on
+ CompuLab SBC-FITPC2 board */
+ .callback = set_bios_reboot,
+ .ident = "CompuLab SBC-FITPC2",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
+ },
+ },
{ }
};

Signature · 2 lines
Sincerely yours,
Mike.
#1 lore raw
Quoted 18 lines · On Mon, 20 Jul 2009 18:48:17 +0300 Mike Rapoport <[email protected]> wrote:
Quoted 1 line

From: Denis Turischev <[email protected]>

This patch adds reboot fixup for CompuLab SBC-fitPC2 board.

diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c linux-2.6.31-rc3/arch/x86/kernel/reboot.c
--- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c 2009-07-14 04:18:52.000000000
+0300
+++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c 2009-07-16 14:39:48.000000000 +0300

(quoted diff) +2 -0
@@ -249,6 +249,15 @@
 			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
 		},
 	},
+	{	/* Handle problems with rebooting on
+				CompuLab SBC-FITPC2 board */

Review line 263

Quoted 10 lines
(quoted diff) +7 -0
+		.callback = set_bios_reboot,
+		.ident = "CompuLab SBC-FITPC2",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
+		},
+	},
 	{ }
 };
 

Neither this patch nor Denis's earlier version contained an adequate decription. We aren't told what these "problems" are, so we're unable to judge the appropriateness of patch.

Both patches were wordwrapped.

Both patches use an atypical layout style for the comments.

I fixed up some of these things and merged the patch into my tree, for sending to Ingo for 2.6.32.

Please send a description of the problem which the patch fixes and I shall add that to my copy of the changelog.

Thanks.

#2 lore raw
Quoted 7 lines · Andrew Morton

Neither this patch nor Denis's earlier version contained an adequate decription. We aren't told what these "problems" are, so we're unable to judge the appropriateness of patch.

Both patches were wordwrapped.

Quoted 8 lines

Both patches use an atypical layout style for the comments.

I fixed up some of these things and merged the patch into my tree, for sending to Ingo for 2.6.32.

Please send a description of the problem which the patch fixes and I shall add that to my copy of the changelog.

I queued up an equivalent cleaned up version for tip:x86/urgent that I was planning to push to Linus. However, as you quite correctly point out the comments in this file are pretty darn pointless; they add absolutely no information over what is already in the data structure.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
#3 lore raw
In reply to Andrew Morton

Hi Andrew,

Quoted 35 lines · Andrew Morton
Quoted 17 lines · On Mon, 20 Jul 2009 18:48:17 +0300 Mike Rapoport <[email protected]> wrote:
Quoted 1 line

From: Denis Turischev <[email protected]>

This patch adds reboot fixup for CompuLab SBC-fitPC2 board.

diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c linux-2.6.31-rc3/arch/x86/kernel/reboot.c
--- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c 2009-07-14 04:18:52.000000000
+0300
+++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c 2009-07-16 14:39:48.000000000 +0300

(quoted diff) +2 -0
@@ -249,6 +249,15 @@
 			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
 		},
 	},
+	{	/* Handle problems with rebooting on
+				CompuLab SBC-FITPC2 board */

Review line 263

Quoted 10 lines
(quoted diff) +7 -0
+		.callback = set_bios_reboot,
+		.ident = "CompuLab SBC-FITPC2",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
+		},
+	},
 	{ }
 };
 

Neither this patch nor Denis's earlier version contained an adequate decription. We aren't told what these "problems" are, so we're unable to judge the appropriateness of patch.

Quoted 1 line

Both patches were wordwrapped.

Sorry, my bad. Somehow I though my mail client can send patches without wrapping them :(

Quoted 8 lines

Both patches use an atypical layout style for the comments.

I fixed up some of these things and merged the patch into my tree, for sending to Ingo for 2.6.32.

Please send a description of the problem which the patch fixes and I shall add that to my copy of the changelog.

sbc-fitpc2 board hangs on reboot without this patch. We saw fixups for Dell and others that set BIOS reboot and that worked for us as well. So, I'd say that changelog entry should be

--
x86: DMI match for CompuLab SBC-FITPC2 as it needs BIOS reboot.

Signature · 1 line
Thanks a lot.
Quoted 2 lines

Thanks.

Signature · 2 lines
Sincerely yours,
Mike.