Skip to contentSkip to conversation

MTD: Correct typo "MTD_DATAFLASH_VERIFY_WRITE".

PATCH In review Robert P. J. Day 2 participants 2 messages Jul 20, 2009 – Jul 21, 2009

Subsystems (2)
Memory technology devices (MTD) Char and misc drivers
lore
Share & tools
lore

Robert P. J. Day

author
#0 lore raw

PATCH 1/1 MTD: Correct typo "MTD_DATAFLASH_VERIFY_WRITE".

Fix the misspelling to match the actual config variable defined in drivers/mtd/devi ces/Kconfig:

config MTD_DATAFLASH_WRITE_VERIFY
bool "Verify DataFlash page writes"
depends on MTD_DATAFLASH

Signed-off-by Robert P. J. Day <[email protected]>

---

you know, there's a *reason* i keep reporting these anomalies...

drivers/char/vr41xx_giu.c deleted +0 -0
deleted file mode 100644
index e69de29..0000000
drivers/mtd/devices/mtd_dataflash.c +2 -2
index 43976aa..70a7369 100644
@@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 		(void) dataflash_waitready(priv->spi);
 
 
-#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
+#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY
 
 		/* (3) Compare to Buffer1 */
 		addr = pageaddr << priv->page_offset;

@@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
 		} else
 			status = 0;
 
-#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
+#endif	/* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */
 
 		remaining = remaining - writelen;
 		pageaddr++;

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

"Kernel Newbie Corner" column @ linux.com: http://cli.gs/WG6WYX
========================================================================

Acked-by Haavard Skinnemoen Acked-by Andrew Victor on v1 1/1
#1 lore raw

Seems correct to me, I'll put it to l2-mtd-2.6.git, thanks.

CCint David who seem to introduced this in the following commit:

commit 8c64038e4c077b2b37c6b27d0c40c77a3ddfaeef

Author: David Brownell <[email protected]>
Date:   Wed Aug 6 21:55:14 2008 -0700

[MTD] make dataflash write-verify be optional

This adds a WRITE_VERIFY Kconfig option to the DataFlash driver, closely mirroring the similar NAND and ONENAND options, giving an option to disable some code that's currently always enabled.

Removing this step probably saves a millisecond or so per page when writing data, which will add up quickly since these pages are small (the largest is 1 KiB). It doesn't seem to add a lot in terms of reliability, and wouldn't detect errors which crop up when transferring data to the on-chip SRAM buffer.

Signed-off-by David Brownell <[email protected]>
Acked-by Haavard Skinnemoen <[email protected]>
Acked-by Andrew Victor <[email protected]>
Signed-off-by David Woodhouse <[email protected]>
Quoted 53 lines · Robert P. J. Day

Fix the misspelling to match the actual config variable defined in drivers/mtd/devi ces/Kconfig:

config MTD_DATAFLASH_WRITE_VERIFY
bool "Verify DataFlash page writes"
depends on MTD_DATAFLASH

Signed-off-by Robert P. J. Day<[email protected]>

---

you know, there's a *reason* i keep reporting these anomalies...

drivers/char/vr41xx_giu.c deleted +0 -0
deleted file mode 100644
index e69de29..0000000
drivers/mtd/devices/mtd_dataflash.c +2 -2
index 43976aa..70a7369 100644
@@ -401,7 +401,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
  		(void) dataflash_waitready(priv->spi);
 
 
-#ifdef CONFIG_MTD_DATAFLASH_VERIFY_WRITE
+#ifdef CONFIG_MTD_DATAFLASH_WRITE_VERIFY
 
  		/* (3) Compare to Buffer1 */
  		addr = pageaddr<<  priv->page_offset;

@@ -430,7 +430,7 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
  		} else
  			status = 0;
 
-#endif	/* CONFIG_MTD_DATAFLASH_VERIFY_WRITE */
+#endif	/* CONFIG_MTD_DATAFLASH_WRITE_VERIFY */
 
  		remaining = remaining - writelen;
  		pageaddr++;

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

"Kernel Newbie Corner" column @ linux.com: http://cli.gs/WG6WYX
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)