Skip to contentSkip to conversation

Allow zero paths for multipath priority groups

PATCH In review Nikanth Karthikesan 3 participants 5 messages Jul 8, 2009 – Jul 22, 2009 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Allow zero paths for multipath priority groups

From: Hannes Reinecke <[email protected]>
Subject: Allow zero paths for multipath priority groups

For correct handling of the all-paths-down scenario we have to allow zero paths as a valid argument for priority groups.

---
 drivers/md/dm-mpath.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/md/dm-mpath.c +2 -2
Index: linux-2.6-dm/drivers/md/dm-mpath.c
===================================================================
@@ -787,8 +787,8 @@ static int multipath_ctr(struct dm_targe
 {
 	/* target parameters */
 	static struct param _params[] = {
-		{1, 1024, "invalid number of priority groups"},
-		{1, 1024, "invalid initial priority group number"},
+		{0, 1024, "invalid number of priority groups"},
+		{0, 1024, "invalid initial priority group number"},
 	};
 
 	int r;
#1 lore raw
Quoted 5 lines · Nikanth Karthikesan

From: Hannes Reinecke <[email protected]>
Subject: Allow zero paths for multipath priority groups

For correct handling of the all-paths-down scenario we have to allow zero paths as a valid argument for priority groups.

That seems counter-intuitive.
Can you be more specific, with example scenarios?

Alasdair

#2 lore raw
Quoted 10 lines · Alasdair G Kergon
Quoted 5 lines · Nikanth Karthikesan

From: Hannes Reinecke <[email protected]>
Subject: Allow zero paths for multipath priority groups

For correct handling of the all-paths-down scenario we have to allow zero paths as a valid argument for priority groups.

That seems counter-intuitive.
Can you be more specific, with example scenarios?

Currently we're not allowing the last path to be removed from a multipath target. With earlier kernel revisions this wasn't a problem as dev_loss_tmo didn't work correctly and so in effect no devices were ever removed from the system.

However, with newer kernels dev_loss_tmo works correctly, so any dead path will be removed from the system.
So when the last path goes down, we're having a stale reference to an sdev which for all intents and purposes should have been removed.

And even worse, when this path comes back the SCSI subsystem isn't even able to assign it to the old device number, as this is already taken.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
#3 lore raw

Then effectively the multipath target with no paths turns into a pure queueing target. I'll have a think about the options, but that's probably quite a reasonable idea.

Alasdair

#4 lore raw
Quoted 4 lines · Alasdair G Kergon

Then effectively the multipath target with no paths turns into a pure queueing target. I'll have a think about the options, but that's probably quite a reasonable idea.

Quite so.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke		      zSeries & Storage
[email protected]			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)