PATCH: veth: Zero timestamp in xmit path.
Subsystems (2)
This patch zero's the timestamp before handing the packet to the peer interface. This lets the peer recalculate the rx timestamp if it cares about timestamps.
The patch is against net-next, compile tested there. Similar patch was functionally tested against 2.6.31-rc3.
drivers/net/veth.c +1 -0
@@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct net_device *dev)if (skb->len > (rcv->mtu +MTU_PAD )) goto rx_drop; + skb->tstamp.tv64 =0 ; skb->pkt_type =PACKET_HOST ; skb->protocol =eth_type_trans (skb, rcv);if (dev->features &NETIF_F_NO_CSUM )
Thanks,
Ben
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
drivers/net/veth.c +1 -0
@@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct net_device *dev)if (skb->len > (rcv->mtu +MTU_PAD )) goto rx_drop; + skb->tstamp.tv64 =0 ; skb->pkt_type =PACKET_HOST ; skb->protocol =eth_type_trans (skb, rcv);if (dev->features &NETIF_F_NO_CSUM )
David Miller
maintainerFrom: Ben Greear <[email protected]>
Date: Tue, 21 Jul 2009 12:46:55 -0700
Quoted 10 lines
This patch zero's the timestamp before handing the packet to the peer interface. This lets the peer recalculate the rx timestamp if it cares about timestamps.
The patch is against net-next, compile tested there. Similar patch was
functionally tested against 2.6.31-rc3.Signed-off-by Ben Greear<[email protected]>
Oh, where to begin... sigh...
The "off" and "by" in "Signed-off-by" is not capitalized.
There should not be two spaces after the Signed-off-by colon, there should be only one.
There should be a space between your name and your <> enclosed email address.
Review static int veth_xmit(struct sk_buff *skb, struct · line 171
Quoted 2 lines
(quoted diff) +0
-0@@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct net_device *dev)
Your email client corrupted the patch by splitting up this line.
This is all just being sloppy, and it shows a lack of care put into your submission.
Nevertheless I'm a sucker and I fixed this all up and applied your patch.
Quoted 16 lines · David Miller
From: Ben Greear<[email protected]>
Date: Tue, 21 Jul 2009 12:46:55 -0700Quoted 10 lines
This patch zero's the timestamp before handing the packet to the peer interface. This lets the peer recalculate the rx timestamp if it cares about timestamps.
The patch is against net-next, compile tested there. Similar patch was
functionally tested against 2.6.31-rc3.Signed-off-by Ben Greear<[email protected]>Oh, where to begin... sigh...
Quoted 7 lines
The "off" and "by" in "Signed-off-by" is not capitalized.
There should not be two spaces after the Signed-off-by colon, there should be only one.
There should be a space between your name and your<> enclosed email address.
I had no idea that was so important.
Quoted 8 lines
Review static int veth_xmit(struct sk_buff *skb, struct · line 171
Quoted 3 lines
(quoted diff) +0
-0@@ -171,6 +171,7 @@ static int veth_xmit(struct sk_buff *skb, struct net_device *dev)Your email client corrupted the patch by splitting up this line.
This is all just being sloppy, and it shows a lack of care put into your submission.
I sent as attachment as well to help mitigate this. If sending only an attachment is better, I will do so next time.
Quoted 2 lines
Nevertheless I'm a sucker and I fixed this all up and applied your patch.
As always, your forbearance is appreciated!
Thanks,
Ben
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
David Miller
maintainerFrom: Ben Greear <[email protected]>
Date: Tue, 21 Jul 2009 13:02:02 -0700
Quoted 10 lines · David Miller
Quoted 9 lines
From: Ben Greear<[email protected]>
Date: Tue, 21 Jul 2009 12:46:55 -0700Quoted 1 line
Signed-off-by Ben Greear<[email protected]>Oh, where to begin... sigh...
The "off" and "by" in "Signed-off-by" is not capitalized.
Quoted 7 lines
Quoted 5 lines
There should not be two spaces after the Signed-off-by colon, there should be only one.
There should be a space between your name and your<> enclosed email address.
I had no idea that was so important.
If you aren't even going to check over such easy and trivial visual matters such as this, one can only imagine how much care has been put into the change itself.
It shows how much you care about how your work and submissions look to other people.
It's as much an issue of what it shows about the submitter's overall mentality as it is an issue of "does it matter" or how important it is to get the signoff syntax correct.