slub: release kobject if sysfs_create_group failed in sysfs_slab_add
Subsystems (2)
PATCH 1/1 slub: release kobject if sysfs_create_group failed in sysfs_slab_add
When CONFIG_SLUB_DEBUG is enabled, sysfs_slab_add should unlink and put the kobject if sysfs_create_group failed. Otherwise, sysfs_slab_add returns error then free kmem_cache s, thus memory of s->kobj is leaked.
Signed-off-by Xiaotian Feng <[email protected]>
--- mm/slub.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
mm/slub.c +4 -1
@@ -4543,8 +4543,11 @@ static int sysfs_slab_add(struct kmem_cache *s) } err =sysfs_create_group (&s->kobj, &slab_attr_group); -if (err) +if (err) { +kobject_del (&s->kobj); +kobject_put (&s->kobj);return err; + }kobject_uevent (&s->kobj,KOBJ_ADD );if (!unmergeable) {/* Setup first alias */
Signature · 7 lines
1.6.2.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Pekka Enberg
AppliedQuoted 6 lines · Xiaotian Feng
When
CONFIG_SLUB_DEBUGis enabled,sysfs_slab_addshould unlink and put the kobject ifsysfs_create_groupfailed. Otherwise,sysfs_slab_addreturns error then freekmem_caches, thus memory ofs->kobjis leaked.Signed-off-by Xiaotian Feng <[email protected]>
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>