Skip to contentSkip to conversation

include/asm-ppc/immap_86xx.h

U-Boot David Updegraff 2 participants 3 messages Jul 22, 2009 – Jul 23, 2009

lore
Share & tools
lore
#0 lore raw

Hi.

I think there is a small offset bug in here.. unless there is an errata that I have missed there should be no pad between srds1cr0,1. Anyone know for sure?

include/asm-ppc/immap_86xx.h +1 -1
@@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
         uint    lbcdllcr;       /* 0xe0e20 - LBC DLL control register */
         char    res13a[224];
         uint    srds1cr0;       /* 0xe0f04 - SerDes1 control register 0 */
-       char    res13b[4];
+       //char  res13b[4];
         uint    srds1cr1;       /* 0xe0f08 - SerDes1 control register 1 */
         char    res14[24];
#1 lore raw
Quoted 20 lines · David Updegraff

Hi.

I think there is a small offset bug in here.. unless there is an errata
that I have missed there should be no pad between srds1cr0,1. Anyone know for sure?

include/asm-ppc/immap_86xx.h +0 -0
@@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
        uint    lbcdllcr;       /* 0xe0e20 - LBC DLL control  

register */

        char    res13a[224];
        uint    srds1cr0;       /* 0xe0f04 - SerDes1 control  

register 0 */

include/asm-ppc/immap_86xx.h +1 -1
-       char    res13b[4];
+       //char  res13b[4];
        uint    srds1cr1;       /* 0xe0f08 - SerDes1 control  

register 1 */

Quoted 1 line
        char    res14[24];

I'm guessing this is a bug in the manual, but will look into it.

- k

#2 lore raw
In reply to David Updegraff
Quoted 20 lines · David Updegraff

Hi.

I think there is a small offset bug in here.. unless there is an errata
that I have missed there should be no pad between srds1cr0,1. Anyone know for sure?

include/asm-ppc/immap_86xx.h +0 -0
@@ -1240,7 +1240,7 @@ typedef struct ccsr_gur {
        uint    lbcdllcr;       /* 0xe0e20 - LBC DLL control  

register */

        char    res13a[224];
        uint    srds1cr0;       /* 0xe0f04 - SerDes1 control  

register 0 */

include/asm-ppc/immap_86xx.h +1 -1
-       char    res13b[4];
+       //char  res13b[4];
        uint    srds1cr1;       /* 0xe0f08 - SerDes1 control  

register 1 */

Quoted 1 line
        char    res14[24];

I've verified and the manual is correct and the code is wrong. If you send a proper patch I'll apply it.

- k