tokenring: Read buffer overflow

PATCH Applied Roel Kluin 2 participants 2 messages Jul 25, 2009 – Jul 27, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Roel Kluin

author

2009-07-25 22:35 UTC #0 lore raw

PATCH 1/1 tokenring: Read buffer overflow

io[i] is read before the bounds check on i, order should be reversed

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/tokenring/ibmtr.c +1 -1

index 9d89611..08a6c41 100644
@@ -1912,7 +1912,7 @@ static int __init ibmtr_init(void)
 
 	find_turbo_adapters(io);
 
-	for (i = 0; io[i] && (i < IBMTR_MAX_ADAPTERS); i++) {
+	for (i = 0; i < IBMTR_MAX_ADAPTERS && io[i]; i++) {
 		struct net_device *dev;
 		irq[i] = 0;
 		mem[i] = 0;

David Miller

maintainer Applied

2009-07-27 02:01 UTC #1 lore raw

From: Roel Kluin <[email protected]>
Date: Sun, 26 Jul 2009 00:38:33 +0200

Quoted 3 lines

io[i] is read before the bounds check on i, order should be reversed
Signed-off-by Roel Kluin <[email protected]>

Applied.