Skip to contentSkip to conversation

Fix failure of the utimensat01 test

PATCH In review Wang Yong 3 participants 6 messages Jul 30, 2009 – Aug 4, 2009

lore
Share & tools
lore

Wang Yong

author
#0 lore raw

PATCH 1/1 Fix failure of the utimensat01 test

The error handling for "RW" opt of run_test brought about error results. This patch fixed that.

Signed-off-by WangYong <[email protected]>

diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh

testcases/kernel/syscalls/utimensat/utimensat_tests.sh +12 -12
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
 echo
 
 echo "***** Testing times==NULL case *****"
-run_test "" 400 "" "" SUCCESS y y
+run_test -W "" 400 "" "" SUCCESS y y
 
 echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test "" 400 "" "0 n 0 n" SUCCESS y y
+run_test -W "" 400 "" "0 n 0 n" SUCCESS y y
 
 echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
-run_test "" 400 "" "0 o 0 o" SUCCESS n n
+run_test -W "" 400 "" "0 o 0 o" SUCCESS n n
 
 echo "***** Testing times=={ UTIME_NOW, UTIME_OMIT } case *****"
-run_test "" 400 "" "0 n 0 o" SUCCESS y n
+run_test -W "" 400 "" "0 n 0 o" SUCCESS y n
 
 echo "***** Testing times=={ UTIME_OMIT, UTIME_NOW } case *****"
-run_test "" 400 "" "0 o 0 n" SUCCESS n y
+run_test -W "" 400 "" "0 o 0 n" SUCCESS n y
 
 echo "***** Testing times=={ x, y } case *****"
-run_test "" 400 "" "1 1 1 1" SUCCESS y y
+run_test -W "" 400 "" "1 1 1 1" SUCCESS y y
 
 echo "============================================================"
 

@@ -284,22 +284,22 @@ echo "Testing read-only file, not owned 
 echo
 
 echo "***** Testing times==NULL case *****"
-run_test root 400 "" "" EACCES
+run_test -RW root 400 "" "" EACCES
 
 echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test root 400 "" "0 n 0 n" EACCES
+run_test -RW root 400 "" "0 n 0 n" EACCES
 
 echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
-run_test root 400 "" "0 o 0 o" SUCCESS n n
+run_test -RW root 400 "" "0 o 0 o" SUCCESS n n
 
 echo "***** Testing times=={ UTIME_NOW, UTIME_OMIT } case *****"
-run_test root 400 "" "0 n 0 o" EPERM
+run_test -RW root 400 "" "0 n 0 o" EPERM
 
 echo "***** Testing times=={ UTIME_OMIT, UTIME_NOW } case *****"
-run_test root 400 "" "0 o 0 n" EPERM
+run_test -RW root 400 "" "0 o 0 n" EPERM
 
 echo "***** Testing times=={ x, y } case *****"
-run_test root 400 "" "1 1 1 1" EPERM
+run_test -RW root 400 "" "1 1 1 1" EPERM
 
 echo "============================================================"

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 11 lines · Wang Yong

The error handling for "RW" opt of run_test brought about error results. This patch fixed that.

Signed-off-by WangYong <[email protected]>

diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh

testcases/kernel/syscalls/utimensat/utimensat_tests.sh    2009-07-28 17:32:26.000000000 +0800 renamed from testcases/kernel/syscalls/utimensat/utimensat_tests.sh    2009-07-28 16:23:39.000000000 +0800 +0 -0
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s

 echo

[...]

Don't these changes actually conflict with the testcase's purpose, given the messages echoed placed directly above the commands? Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#2 lore raw

Garrett Cooper wrote as:

Quoted 17 lines · Wang Yong
Quoted 13 lines

The error handling for "RW" opt of run_test brought about error results. This patch fixed that.

Signed-off-by WangYong <[email protected]>

diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh

testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 17:32:26.000000000 +0800 renamed from testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800 +0 -0
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
 echo

[...]

Quoted 6 lines

Don't these changes actually conflict with the testcase's purpose, given the messages echoed placed directly above the commands? Thanks,
-Garrett

Hi Garrett,

This patch doesn't change the testcase's purpose.
And the test results prove it.

Best regards,
Wang Yong

Quoted 2 lines

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
Quoted 24 lines · Wang Yong

Garrett Cooper wrote as:

Quoted 17 lines · Wang Yong
Quoted 13 lines

The error handling for "RW" opt of run_test brought about error results. This patch fixed that.

Signed-off-by WangYong <[email protected]>

diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh

testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 17:32:26.000000000 +0800 renamed from testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800 +0 -0
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
 echo

[...]

Quoted 6 lines

Don't these changes actually conflict with the testcase's purpose, given the messages echoed placed directly above the commands? Thanks,
-Garrett

Quoted 4 lines

Hi Garrett,

This patch doesn't change the testcase's purpose.
And the test results prove it.

However, a much broader explanation of the Patch and itś purpose would indeed help a great deal.

Regards--
Subrata

Quoted 10 lines

Best regards,
Wang Yong

Quoted 2 lines
Quoted 9 lines

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#4 lore raw
In reply to Wang Yong
Quoted 31 lines · Wang Yong

Garrett Cooper wrote as:

Quoted 22 lines
Quoted 15 lines · Wang Yong

The error handling for "RW" opt of run_test brought about error results. This patch fixed that.

Signed-off-by WangYong <[email protected]>

diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh

 2009-07-28 16:23:39.000000000 +0800
+++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
 2009-07-28 17:32:26.000000000 +0800
(quoted diff) +0 -0
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s

 echo

[...]

Quoted 6 lines

Don't these changes actually conflict with the testcase's purpose, given the messages echoed placed directly above the commands? Thanks,
-Garrett

Quoted 4 lines

Hi Garrett,

This patch doesn't change the testcase's purpose.
And the test results prove it.

Wang,
You're changing everything to RW -- how is that not contradicting
the phrase `Testing read-only file'?
Just because things fail doesn't necessarily mean that the entire
intent is incorrect. Let's make sure not to lose sight of that point :).
Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#5 lore raw

Garrett Cooper wrote as:

Quoted 38 lines · Wang Yong
Quoted 31 lines

Garrett Cooper wrote as:

Quoted 21 lines
Quoted 15 lines · Wang Yong

The error handling for "RW" opt of run_test brought about error results. This patch fixed that.

Signed-off-by WangYong <[email protected]>

diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh

 2009-07-28 16:23:39.000000000 +0800
+++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
 2009-07-28 17:32:26.000000000 +0800
(quoted diff) +0 -0
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
 echo

[...]

Quoted 7 lines

Don't these changes actually conflict with the testcase's purpose, given the messages echoed placed directly above the commands? Thanks,
-Garrett

Quoted 5 lines

Hi Garrett,

This patch doesn't change the testcase's purpose.
And the test results prove it.

Quoted 10 lines

Wang,
You're changing everything to RW -- how is that not contradicting
the phrase `Testing read-only file'?
Just because things fail doesn't necessarily mean that the entire
intent is incorrect. Let's make sure not to lose sight of that point :).
Thanks,
-Garrett

Hi,

Thanks for your advice.
I did change the testcase's purpose when I changed the "RW" opt. And I will make patch in accordance with
the principle of not changing the testcase's purpose.

Thanks,
-Wang Yong

Quoted 2 lines

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list