Skip to contentSkip to conversation

osst: Read buffer overflow

PATCH New Roel Kluin 1 participant 1 message Aug 2, 2009 SCSI

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 osst: Read buffer overflow

Check whether index is within bounds before testing the element.

---

drivers/scsi/osst.c +2 -1
index acb8358..ddb3d06 100644
@@ -5860,7 +5860,8 @@ static int osst_probe(struct device *dev)
 	}
 
 	/* find a free minor number */
-	for (i=0; os_scsi_tapes[i] && i<osst_max_dev; i++);
+	for (i = 0; i < osst_max_dev && os_scsi_tapes[i]; i++)
+		;
 	if(i >= osst_max_dev) panic ("Scsi_devices corrupt (osst)");
 	dev_num = i;