Skip to contentSkip to conversation

c/r: Fix no-dot-config-targets pattern in linux/Makefile

PATCH In review John Dykstra 2 participants 4 messages Aug 3, 2009 – Aug 4, 2009 1 message not in the archive Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 c/r: Fix no-dot-config-targets pattern in linux/Makefile

Oren, I'm not sure who you're accepting patches from, but...

--
Kernel builds that specify targets in the checkpoint/ directory will fail or be incorrect because the autoconfig files were not included. One way to reproduce the problem is:

make checkpoint/sys.s

The problem is that this pattern in linux/Makefile matches files in the checkpoint/ directory:

no-dot-config-targets := clean mrproper distclean \
                         cscope TAGS tags help %docs check% \
                         include/linux/version.h headers_% \
                         kernelrelease kernelversion

Make the pattern more exact, per the current set of linux build targets.

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index cf631d7..17445a6 100644
@@ -400,7 +400,7 @@ endif
 # of make so .config is not included in this case either (for *config).
 
 no-dot-config-targets := clean mrproper distclean \
-			 cscope TAGS tags help %docs check% \
+			 cscope TAGS tags help %docs checkstack \
 			 include/linux/version.h headers_% \
 			 kernelrelease kernelversion
 
Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 1 line · John Dykstra

Oren, I'm not sure who you're accepting patches from, but...

I accept any good patch :)
(pushed to ckpt-v17-dev)

Oren.

Quoted 36 lines

--
Kernel builds that specify targets in the checkpoint/ directory will fail or be incorrect because the autoconfig files were not included. One way to reproduce the problem is:

make checkpoint/sys.s

The problem is that this pattern in linux/Makefile matches files in the checkpoint/ directory:

no-dot-config-targets := clean mrproper distclean \
                         cscope TAGS tags help %docs check% \
                         include/linux/version.h headers_% \
                         kernelrelease kernelversion

Make the pattern more exact, per the current set of linux build targets.

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index cf631d7..17445a6 100644
@@ -400,7 +400,7 @@ endif
 # of make so .config is not included in this case either (for *config).
 
 no-dot-config-targets := clean mrproper distclean \
-			 cscope TAGS tags help %docs check% \
+			 cscope TAGS tags help %docs checkstack \
 			 include/linux/version.h headers_% \
 			 kernelrelease kernelversion
 

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 2 lines · Oren Laadan

I accept any good patch :)

What's a good way to package the patch on the list so that you'll notice it, but it will still be clear that it's not intended for mainline?

-- John

#4 lore raw
Quoted 5 lines · John Dykstra
Quoted 1 line · Oren Laadan

I accept any good patch :)

What's a good way to package the patch on the list so that you'll notice it, but it will still be clear that it's not intended for mainline?

Since c/r is not (yet) in mainline, 'c/r' prefix and cc'ing me should make it visible enough.

Thanks,

Oren.