Trizeps IV adaptation to changes in dm9000 driver
PATCH 1/1 Trizeps IV adaptation to changes in dm9000 driver
From: Stefano Babic <[email protected]>
Last patch in the dm9000 driver breaks the trizeps IV board (PXA). Reading of eeprom is modified here to reflect the changes in read_srom_word().
--- board/trizepsiv/eeprom.c | 10 ++++++---- drivers/net/dm9000x.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-)
board/trizepsiv/eeprom.c +6 -4
@@ -24,16 +24,18 @@#include <common.h> #include <command.h> -extern u16 read_srom_word (int ); +extern void read_srom_word (int ,u8 *);extern void write_srom_word (int offset,u16 val);static int do_read_dm9000_eeprom (cmd_tbl_t *cmdtp,int flag,int argc,char *argv[]) { -int i; +unsigned int i; +u8 value;for (i=0 ; i <0x40 ; i++) {if (!(i %0x10 )) -printf ("\n%08lx:" , i); -printf (" %04x" ,read_srom_word (i)); +printf ("\n%08x:" , i); +read_srom_word (i, &value); +printf (" %04x" , value); }printf ("\n" );return (0 );
drivers/net/dm9000x.c +2 -2
@@ -113,7 +113,7 @@ void eth_halt(void);static int dm9000_probe (void );static u16 phy_read (int );static void phy_write (int ,u16 ); -static void read_srom_word (int ,u8 *); +void read_srom_word (int ,u8 *);static u8 DM9000_ior (int );static void DM9000_iow (int reg,u8 value);
@@ -541,7 +541,7 @@ eth_rx(void)/* Read a word data from SROM */ -static void read_srom_word (int offset,u8 *to) +void read_srom_word (int offset,u8 *to) {DM9000_iow (DM9000_EPAR , offset);DM9000_iow (DM9000_EPCR ,0x4 );
Signature · 1 line
1.6.0.4
PATCH 1/1 Trizeps IV adaptation to changes in dm9000 driver
Dear Ben,
Quoted 11 lines · In message <[email protected]> Stefano Babic…
From: Stefano Babic <[email protected]>
Last patch in the dm9000 driver breaks the trizeps IV board (PXA). Reading of eeprom is modified here to reflect the changes in
read_srom_word().Signed-off-by Stefano Babic <[email protected]>--- board/trizepsiv/eeprom.c | 10 ++++++---- drivers/net/dm9000x.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-)
AFAICT this has neither been applied nor rejected yet. Please check. [I suggest you pull it, even though it contains a small snippet of non-network code. Thanks.]
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Teenagers are people who express a burning desire to be different by dressing exactly alike. There are some strings. They're just not attached.
PATCH 1/1 Trizeps IV adaptation to changes in dm9000 driver
Dear Ben,
Quoted 16 lines · In message <[email protected]> I wrote:
Dear Ben,
Quoted 11 lines · In message <[email protected]> Stefano Babic…
From: Stefano Babic <[email protected]>
Last patch in the dm9000 driver breaks the trizeps IV board (PXA). Reading of eeprom is modified here to reflect the changes in
read_srom_word().Signed-off-by Stefano Babic <[email protected]>--- board/trizepsiv/eeprom.c | 10 ++++++---- drivers/net/dm9000x.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-)
Quoted 3 lines
AFAICT this has neither been applied nor rejected yet. Please check. [I suggest you pull it, even though it contains a small snippet of non-network code. Thanks.]
Ping!!
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Common sense and a sense of humor are the same thing, moving at
different speeds. A sense of humor is just common sense, dancing.
- Clive JamesPATCH 1/1 Trizeps IV adaptation to changes in dm9000 driver
Quoted 25 lines · Wolfgang Denk
Dear Ben,
Quoted 16 lines · In message <[email protected]> I wrote:
Dear Ben,
Quoted 6 lines · In message <[email protected]> Stefano Babic…
From: Stefano Babic <[email protected]>
Last patch in the dm9000 driver breaks the trizeps IV board (PXA). Reading of eeprom is modified here to reflect the changes in
read_srom_word().Quoted 6 lines
Signed-off-by Stefano Babic <[email protected]>--- board/trizepsiv/eeprom.c | 10 ++++++---- drivers/net/dm9000x.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-)Quoted 4 lines
AFAICT this has neither been applied nor rejected yet. Please check. [I suggest you pull it, even though it contains a small snippet of non-network code. Thanks.]
Quoted 7 lines
Ping!!
Best regards,
Wolfgang Denk
Sorry, I missed your 7/17 e-mail. Will take care of it tonight.
regards,
Ben
PATCH 1/1 Trizeps IV adaptation to changes in dm9000 driver
In reply to Wolfgang DenkWolfgang,
Quoted 25 lines · Wolfgang Denk
Dear Ben,
Quoted 16 lines · In message <[email protected]> I wrote:
Dear Ben,
Quoted 6 lines · In message <[email protected]> Stefano Babic…
From: Stefano Babic <[email protected]>
Last patch in the dm9000 driver breaks the trizeps IV board (PXA). Reading of eeprom is modified here to reflect the changes in
read_srom_word().Quoted 6 lines
Signed-off-by Stefano Babic <[email protected]>--- board/trizepsiv/eeprom.c | 10 ++++++---- drivers/net/dm9000x.c | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-)Quoted 4 lines
AFAICT this has neither been applied nor rejected yet. Please check. [I suggest you pull it, even though it contains a small snippet of non-network code. Thanks.]
Quoted 7 lines
Ping!!
Best regards,
Wolfgang Denk
It looks to me that the problem this addresses no longer exists.
Stefano - please verify.
regards,
Ben