zorro8390: Fix read buffer overflow in zorro8390_init_one()

PATCH New Roel Kluin 1 participant 1 message Aug 9, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Roel Kluin

author

2009-08-09 13:56 UTC #0 lore raw

PATCH 1/1 zorro8390: Fix read buffer overflow in zorro8390_init_one()

Prevent read from cards[-1] when no card was found.

Signed-off-by Roel Kluin <[email protected]>

---
is ENODEV appropriate here?

drivers/net/zorro8390.c +3 -0

index 37c84e3..55502e1 100644
@@ -120,6 +120,9 @@ static int __devinit zorro8390_init_one(struct zorro_dev *z,
     for (i = ARRAY_SIZE(cards)-1; i >= 0; i--)
 	if (z->id == cards[i].id)
 	    break;
+    if (i < 0)
+        return -ENODEV;
+    
     board = z->resource.start;
     ioaddr = board+cards[i].offset;
     dev = alloc_ei_netdev();