fix lib6 test building

The lib6 tests seem to fail the first pass through building for me because ranlib does not seem to get set correctly at any point. This seems to fix it up for me.

Thanks,
Paul Larson

Fix build problem with lib6 tests

---

index 7c1784d..f622468 100644
@@ -23,6 +23,10 @@
 CFLAGS+=	-I../../../include -g -D_GNU_SOURCE
 LOADLIBES+=	-L../../../lib runcc.a -lltp -lpthread
 
+ifeq ($(RANLIB),)
+RANLIB = ranlib
+endif
+
 SRCS=$(wildcard *.c)
 TARGETS= asapi_01 asapi_02 asapi_03 asapi_04 asapi_05 asapi_06 asapi_07 \
 	getaddrinfo_01 in6_01 in6_02

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Fixed on HEAD moments ago:

gcooper@orangebox /scratch/ltp-dev2/ltp $ cvs diff testcases/network/lib6/Makefile
Index: testcases/network/lib6/Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/network/lib6/Makefile,v retrieving revision 1.6
diff -r1.6 Makefile
25a26,27

The problem is that while configure specifies RANLIB, make doesn't. So if you don't run from a top-level make, there's no guarantee [today] that the right variables will be set. This will be fixed soon.

If cross-compiling, please specify $(CROSS_COMPILE)ranlib, and the compile will go through in the child make.

Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

The patch you checked in does not correct the build failure.

Thanks,
Paul Larson

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Paul,

The patch above applied to version 1.5 of the make file works fo me across multiple architectures. It turned out that RANLIB was not needed, as long as the appropriate AR was used. It had been hardcoded in 1.4. Let me know if that works.

-----Original Message-----
From: Paul Larson [mailto:[email protected]]
Sent: Wednesday, August 12, 2009 8:13 AM
To: Garrett Cooper
Cc: [email protected]
Subject: Re: [LTP] fix lib6 test building

The patch you checked in does not correct the build failure.

Thanks,
Paul Larson

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

@@ -38,4 +38,4 @@
 	rm -f $(TARGETS) *.a *.o
 
 runcc.a: runcc.o
-	ar cr runcc.a runcc.o
+	$(AR) cr runcc.a runcc.o

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Error message please?
Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Same error as before:
make[3]: Entering directory `/home/plars/ltp2/testcases/network/lib6'
cc -Wall -I../../../include -g -D_GNU_SOURCE -c -o runcc.o runcc.c
ar cr runcc.a runcc.o
runcc.a
make[3]: runcc.a: Command not found
make[3]: *** [runcc.a] Error 127
make[3]: Leaving directory `/home/plars/ltp2/testcases/network/lib6' make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/plars/ltp2/testcases/network' make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/plars/ltp2/testcases'
make: *** [all] Error 2

My make-foo is a bit rusty, but I'm guessing that the higher level export is exporting an empty RANLIB, so the RANLIB ?= ranlib is not doing anything since RANLIB already exists.

Thanks,
Paul Larson

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

You're right. I've just fixed it on HEAD with the following comment:

Index: Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/Makefile,v
retrieving revision 1.40

diff -u -r1.40 Makefile
@@ -7,6 +7,11 @@
 CC=$(CROSS_COMPILER)gcc
 AR=$(CROSS_COMPILER)ar
 RANLIB=$(CROSS_COMPILER)ranlib
+else
+# RANLIB isn't a standard Make variable, which means that when it's exported
+# to leaf callers as an empty value, builds fail.
+# testcases/network/lib6/Makefile is a prime example.
+RANLIB?=ranlib
 endif
 
 HAS_NUMA=$(shell sh tools/scripts/numa_test.sh)

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list