Skip to contentSkip to conversation

zr364: wrong indexes

PATCH In review Roel Kluin 2 participants 2 messages Aug 11, 2009 – Aug 13, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 zr364: wrong indexes

The order of indexes is reversed

Signed-off-by Roel Kluin <[email protected]>

---
Right?

drivers/media/video/zr364xx.c +1 -1
index fc976f4..2622a6e 100644
@@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file)
 	for (i = 0; i < 2; i++) {
 		err =
 		    send_control_msg(udev, 1, init[cam->method][i].value,
-				     0, init[i][cam->method].bytes,
+				     0, init[cam->method][i].bytes,
 				     init[cam->method][i].size);
 		if (err < 0) {
 			dev_err(&udev->dev, "error during release sequence\n");
#1 lore raw

Hi,

You are right, thanks for fixing this bug.
I have pushed your patch to my tree.

Best regards,

Antoine

Quoted 23 lines · Roel Kluin

The order of indexes is reversed

Signed-off-by Roel Kluin <[email protected]>

---
Right?

drivers/media/video/zr364xx.c +1 -2
index fc976f4..2622a6e 100644
@@ -695,7 +695,7 @@ static int zr364xx_release(struct file *file)
 	for (i = 0; i < 2; i++) {
 		err =
 		    send_control_msg(udev, 1, init[cam->method][i].value,
-				     0, init[i][cam->method].bytes,
+				     0, init[cam->method][i].bytes,
 				     init[cam->method][i].size);
 		if (err < 0) {
 			dev_err(&udev->dev, "error during release sequence\n");
--

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html