p54: disable PS by default

PATCH In review Christian Lamparter 2 participants 2 messages Aug 14, 2009 – Aug 15, 2009 Networking drivers (wireless)

Share & tools

Christian Lamparter

author

2009-08-14 11:23 UTC #0 lore raw

PATCH 1/1 p54: disable PS by default

Johannes kindly pointed out that I completely missed a hunk in his patch: "[PATCH] cfg80211: allow driver to override PS default".

The driver must explicitly set ps_default to false, as the setting is pre-filled with the kconfig default.

Signed-off-by Christian Lamparter <[email protected]>

---

drivers/net/wireless/p54/main.c +6 -0

index 4a741df..77203e3 100644
@@ -575,6 +575,12 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
 	dev->extra_tx_headroom = sizeof(struct p54_hdr) + 4 +
 				 sizeof(struct p54_tx_data);
 
+	/*
+	 * For now, disable PS by default because it affects
+	 * link stability significantly.
+	 */
+	dev->wiphy->ps_default = false;
+
 	mutex_init(&priv->conf_mutex);
 	mutex_init(&priv->eeprom_mutex);
 	init_completion(&priv->eeprom_comp);

Larry Finger

2009-08-15 20:00 UTC #1 lore raw

Quoted 8 lines · Christian Lamparter

Johannes kindly pointed out that I completely missed a hunk in his patch: "[PATCH] cfg80211: allow driver to override PS default".
The driver must explicitly set ps_default to false, as the setting is pre-filled with the kconfig default.
Signed-off-by Christian Lamparter <[email protected]>
---

With this patch, I no longer see the disconnects. ACK.

Larry