Skip to contentSkip to conversation

b43: LP-PHY: Remove BROKEN from B43_PHY_LP

PATCH In review Gábor Stefanik 2 participants 2 messages Aug 16, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 b43: LP-PHY: Remove BROKEN from B43_PHY_LP

Larry has reported success getting scan data with an LP-PHY device, so it's probably time to release LP-PHY support for testing.

Also disable 802.11a support for now, as 802.11a currently causes the driver to panic on startup (NULL pointer dereference).

---
V2:
-Remove "VERY" from the warning in the symbol name.
-Remove list of known devices.
-Don't create a separate symbol for 5GHz, just disable it in the code.

drivers/net/wireless/b43/Kconfig | 14 +++++++-------
drivers/net/wireless/b43/main.c | 2 ++

2 files changed, 9 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/Kconfig +0 -0
index 67f564e..237b1aa 100644
@@ -80,16 +80,16 @@ config B43_NPHY

SAY N.

config B43_PHY_LP
- bool "IEEE 802.11g LP-PHY support (BROKEN)"
- depends on B43 && EXPERIMENTAL && BROKEN
+ bool "Support for low-power (LP-PHY) devices (EXPERIMENTAL)"
+ depends on B43 && EXPERIMENTAL

	---help---
	  Support for the LP-PHY.
-	  The LP-PHY is an IEEE 802.11g based PHY built into some notebooks
-	  and embedded devices.
-
-	  THIS IS BROKEN AND DOES NOT WORK YET.
+	  The LP-PHY is a low-power PHY built into some notebooks
+	  and embedded devices. It supports 802.11a/g
+	  (802.11a support is optional, and currently disabled).
-	  SAY N.
+	  This is heavily experimental, and probably will not work for you.
+	  Say N unless you want to help debug the driver.

# This config option automatically enables b43 LEDS support,

# if it's possible.
drivers/net/wireless/b43/main.c +0 -0
index 99b41ce..c5bece0 100644
@@ -4514,7 +4514,9 @@ static int b43_wireless_core_attach(struct b43_wldev *dev)
			have_5ghz_phy = 1;
			break;
		case B43_PHYTYPE_LP: //FIXME not always!
+#if 0 //FIXME enabling 5GHz causes a NULL pointer dereference
			have_5ghz_phy = 1;
+#endif
		case B43_PHYTYPE_G:
		case B43_PHYTYPE_N:
			have_2ghz_phy = 1;
Signature · 1 line
1.6.2.4
#1 lore raw
Quoted 7 lines · On Sunday 16 August 2009 20:22:41 Gábor Stefanik wrote:

Larry has reported success getting scan data with an LP-PHY device, so it's probably time to release LP-PHY support for testing.

Also disable 802.11a support for now, as 802.11a currently causes the driver to panic on startup (NULL pointer dereference).

ack

Quoted 52 lines

---
V2:

(quoted diff) +0 -3
-Remove "VERY" from the warning in the symbol name.
-Remove list of known devices.
-Don't create a separate symbol for 5GHz, just disable it in the code.
 
 drivers/net/wireless/b43/Kconfig |   14 +++++++-------
 drivers/net/wireless/b43/main.c  |    2 ++
 2 files changed, 9 insertions(+), 7 deletions(-)
drivers/net/wireless/b43/Kconfig +7 -7
index 67f564e..237b1aa 100644
@@ -80,16 +80,16 @@ config B43_NPHY
 	  SAY N.
 
 config B43_PHY_LP
-	bool "IEEE 802.11g LP-PHY support (BROKEN)"
-	depends on B43 && EXPERIMENTAL && BROKEN
+	bool "Support for low-power (LP-PHY) devices (EXPERIMENTAL)"
+	depends on B43 && EXPERIMENTAL
 	---help---
 	  Support for the LP-PHY.
-	  The LP-PHY is an IEEE 802.11g based PHY built into some notebooks
-	  and embedded devices.
-
-	  THIS IS BROKEN AND DOES NOT WORK YET.
+	  The LP-PHY is a low-power PHY built into some notebooks
+	  and embedded devices. It supports 802.11a/g
+	  (802.11a support is optional, and currently disabled).
 
-	  SAY N.
+	  This is heavily experimental, and probably will not work for you.
+	  Say N unless you want to help debug the driver.
 
 # This config option automatically enables b43 LEDS support,
 # if it's possible.
drivers/net/wireless/b43/main.c +2 -0
index 99b41ce..c5bece0 100644
@@ -4514,7 +4514,9 @@ static int b43_wireless_core_attach(struct b43_wldev *dev)
 			have_5ghz_phy = 1;
 			break;
 		case B43_PHYTYPE_LP: //FIXME not always!
+#if 0 //FIXME enabling 5GHz causes a NULL pointer dereference
 			have_5ghz_phy = 1;
+#endif
 		case B43_PHYTYPE_G:
 		case B43_PHYTYPE_N:
 			have_2ghz_phy = 1;
Signature · 1 line
Greetings, Michael.