Skip to contentSkip to conversation

input: Rename keypad and ts platform driver for w90p910

PATCH In review Wan ZongShun 2 participants 5 messages Aug 17, 2009 – Aug 18, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: Rename keypad and ts platform driver for w90p910

Dear Dmitry,

Due to I modified the corresponding platform device name, so I make the patch to rename keypad and ts platform driver for w90p910 platform.

Thanks!

---
 drivers/input/keyboard/w90p910_keypad.c |    4 ++--
 drivers/input/touchscreen/w90p910_ts.c  |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/input/keyboard/w90p910_keypad.c +2 -2
index 24096cd..ada30ee 100644
@@ -267,7 +267,7 @@ static struct platform_driver w90p910_keypad_driver = {
 	.probe		= w90p910_keypad_probe,
 	.remove		= __devexit_p(w90p910_keypad_remove),
 	.driver		= {
-		.name	= "w90p910-keypad",
+		.name	= "nuc900-keypad",
 		.owner	= THIS_MODULE,
 	},
 };
@@ -288,4 +288,4 @@ module_exit(w90p910_keypad_exit);
 MODULE_AUTHOR("Wan ZongShun <[email protected]>");
 MODULE_DESCRIPTION("w90p910 keypad driver!");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:w90p910-keypad");
+MODULE_ALIAS("platform:nuc900-keypad");
drivers/input/touchscreen/w90p910_ts.c +2 -2
index 6071f58..937dfe4 100644
@@ -326,7 +326,7 @@ static struct platform_driver w90x900ts_driver = {
 	.probe		= w90x900ts_probe,
 	.remove		= __devexit_p(w90x900ts_remove),
 	.driver		= {
-		.name	= "w90x900-ts",
+		.name	= "nuc900-ts",
 		.owner	= THIS_MODULE,
 	},
 };
@@ -347,4 +347,4 @@ module_exit(w90x900ts_exit);
 MODULE_AUTHOR("Wan ZongShun <[email protected]>");
 MODULE_DESCRIPTION("w90p910 touch screen driver!");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:w90p910-ts");
+MODULE_ALIAS("platform:nuc900-ts");
Signature · 1 line
1.5.6.3
maintainer
#1 lore raw
Quoted 6 lines · Wan ZongShun

Dear Dmitry,

Due to I modified the corresponding platform device name, so I make the patch to rename keypad and ts platform driver for w90p910 platform.

Do we really need to go through renaming the drivers just because the company changed it's name?

Signature · 1 line
Dmitry
#2 lore raw

Dear Dmitry,

Sir, Due to only w90p910 was renamed, other CPUs of the series originally was named after NUC9xx,
the ts and keypad was public use by w90p910 ,nuc950 and nuc920, so, if the 'w90p910-ts' and 'w90p910-keypad' could not be renamed ,I have to make the platform device names of nuc920 and nuc960 named after 'w90p910-ts' and 'w90p910-keypad' too, Hmm, I think it is so confused. Also, it is my mistake not to map out well my w90x900 series platform before submitting it.

But, if you insist on, I think I can obey without question.

Thanks!

2009/8/17 Dmitry Torokhov <[email protected]>:

Quoted 14 lines · Wan ZongShun
Quoted 6 lines

Dear Dmitry,

Due to I modified the corresponding platform device name, so I make the patch to rename keypad and ts platform driver for w90p910 platform.

Do we really need to go through renaming the drivers just because the company changed it's name?

--
Dmitry

Signature · 1 line
Wan z.s
maintainer
#3 lore raw

Hi Wan,

Quoted 5 lines · Wan ZongShun

Dear Dmitry,

Sir, Due to only w90p910 was renamed, other CPUs of the series originally was named after NUC9xx,
the ts and keypad was public use by w90p910 ,nuc950 and nuc920,

OK, I see.

so, if

Quoted 3 lines

the 'w90p910-ts' and 'w90p910-keypad' could not be renamed ,I have to make the platform device names of nuc920 and nuc960 named after 'w90p910-ts' and 'w90p910-keypad' too, Hmm, I think it is so confused.

May I suggest calling the driver/devices nuc9xx-ts and nuc9xx-ts? Then you should have some wiggle room. Also I think you should push out the patches changing driver names together with your platform code (and not through subsystem trees), otheriwse there will be a period when drivers stop binding to your devices. Just make sure you get Acks from the maintainers and you should be set.

And please adjust the Kconfig entries to mention the other chipsets as well.

Signature · 1 line
Dmitry
#4 lore raw

Dear sir,

2009/8/18 Dmitry Torokhov <[email protected]>:

Quoted 9 lines

Hi Wan,

Quoted 5 lines · Wan ZongShun

Dear Dmitry,

Sir, Due to only w90p910 was renamed, other CPUs of the series originally was named after NUC9xx,
the ts and keypad was public use by w90p910 ,nuc950 and nuc920,

Quoted 8 lines

OK, I see.

 so, if

Quoted 3 lines

the 'w90p910-ts' and 'w90p910-keypad' could not be renamed ,I have to make the platform device names of nuc920 and nuc960 named after 'w90p910-ts' and 'w90p910-keypad' too, Hmm, I think it is so confused.

May I suggest calling the driver/devices nuc9xx-ts and nuc9xx-ts?

Sir, I prefer these nuc9xx more than nuc900 too for representing the series SoCs,
but, it just be my embarrassing, I have argued this Naming issue with Nuvoton, and they did not agree me and prefer to use nuc900.

I know well it should not have company politics in Linux community, but I have to
consider their point of view sometimes.

Quoted 5 lines

Then you should have some wiggle room. Also I think you should push out the patches changing driver names together with your platform code (and not through subsystem trees), otheriwse there will be a period when drivers stop binding to your devices. Just make sure you get Acks from the maintainers and you should be set.

Sir, good idea, Can the patch be merged into my platform patch and submit Russell's list?
I had hoped that this patches and platform patches could appear at the same time in 2.6.32-rc1,
so ,regarding miss binding ,there 's no likelihood of it happening.
It should be so?

Quoted 2 lines

And please adjust the Kconfig entries to mention the other chipsets as well.

Ok. thanks!

Quoted 3 lines

--
Dmitry

Signature · 5 lines
Wan z.s
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html