staging/sep: fix build error & warning & kconfig
Subsystems (2)
PATCH 1/1 staging/sep: fix build error & warning & kconfig
From: Randy Dunlap <[email protected]>
Fix sep_driver build when CONFIG_PCI=n:
drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'
and printk format warning:
drivers/staging/sep/sep_driver.c:290:
warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned
int'
Also, the default kconfig value should not be 'y'.
And something should be done about this warning (but I didn't fix it):drivers/staging/sep/sep_driver.c:1780: warning: 'error' may be used uninitialized in this function
--- drivers/staging/sep/Kconfig | 3 +-- drivers/staging/sep/sep_driver.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/staging/sep/Kconfig +1 -2
@@ -1,8 +1,7 @@ config DX_SEP tristate "Discretix SEP driver" # depends on MRST - depends on RAR_REGISTER - default y + depends on RAR_REGISTER && PCI help Discretix SEP driver
drivers/staging/sep/sep_driver.c +1 -1
@@ -287,7 +287,7 @@ static int sep_map_and_alloc_shared_area sep->shared_area = sep->shared_addr;/* set the physical address of the shared area */ sep->shared_area_bus = sep->shared_bus; -edbg ("sep: shared_area %d bytes @%p (bus %08llx)\n" , +edbg ("sep: shared_area %lu bytes @%p (bus %08llx)\n" , size, sep->shared_addr, (unsigned long long )sep->shared_bus);return 0 ; }
Signature · 3 lines
~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/
Quoted 5 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix
sep_driverbuild whenCONFIG_PCI=n:
drivers/staging/sep/sep_driver.c:2548: error: implicit declaration of function 'pci_dev_get'
I just merged a patch to fix this a few minutes ago.
Quoted 5 lines
and printk format warning:
drivers/staging/sep/sep_driver.c:290:
warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned
int'
I think Alan is taking care of this stuff already.
Quoted 4 lines
Also, the default kconfig value should not be 'y'.
And something should be done about this warning (but I didn't fix it):
drivers/staging/sep/sep_driver.c:1780: warning: 'error' may be used uninitialized in this function
Alan has already resolved this one.
thanks,
greg k-h