Skip to contentSkip to conversation

sched: use for_each_class macro in move_one_task()

PATCH In review Hiroshi Shimamoto 1 participant 2 messages Aug 18, 2009 – Aug 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: use for_each_class macro in move_one_task()

From: Hiroshi Shimamoto <[email protected]>

Replace for loop with the macro for_each_class to cleanup.

---
 kernel/sched.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/sched.c +2 -1
index 5184580..d559fa7 100644
@@ -3461,9 +3461,10 @@ static int move_one_task(struct rq *this_rq, int this_cpu, struct rq *busiest,
 {
 	const struct sched_class *class;
 
-	for (class = sched_class_highest; class; class = class->next)
+	for_each_class(class) {
 		if (class->move_one_task(this_rq, this_cpu, busiest, sd, idle))
 			return 1;
+	}
 
 	return 0;
 }
Signature · 1 line
1.6.3.3
#1 lore raw

[tip:sched/core] sched: Use for_each_class macro in move_one_task()

Commit-ID:  cde7e5ca4e329a157108769d1f752d191cbb71c6
Gitweb:     http://git.kernel.org/tip/cde7e5ca4e329a157108769d1f752d191cbb71c6
Author:     Hiroshi Shimamoto <[email protected]>
AuthorDate: Tue, 18 Aug 2009 13:01:01 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 20 Aug 2009 13:00:30 +0200

sched: Use for_each_class macro in move_one_task()

Replace for loop with the macro for_each_class to cleanup.

LKML-Reference: <[email protected]>

---
 kernel/sched.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/sched.c +2 -1
index 7f83be3..1b529ef 100644
@@ -3461,9 +3461,10 @@ static int move_one_task(struct rq *this_rq, int this_cpu, struct rq *busiest,
 {
 	const struct sched_class *class;
 
-	for (class = sched_class_highest; class; class = class->next)
+	for_each_class(class) {
 		if (class->move_one_task(this_rq, this_cpu, busiest, sd, idle))
 			return 1;
+	}
 
 	return 0;
 }