Skip to contentSkip to conversation

ocfs2: Add missing lock name

PATCH New Jan Kara 3 participants 3 messages Aug 20, 2009 OCFS2

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

PATCH 1/1 ocfs2: Add missing lock name

There is missing name for NFSSync cluster lock. This makes lockdep unhappy because we end up passing NULL to lockdep when initializing lock key. Fix it.

---
 fs/ocfs2/ocfs2_lockid.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ocfs2/ocfs2_lockid.h +1 -0
index fcdba09..c212cf5 100644
@@ -108,6 +108,7 @@ static char *ocfs2_lock_type_strings[] = {
 	[OCFS2_LOCK_TYPE_OPEN] = "Open",
 	[OCFS2_LOCK_TYPE_FLOCK] = "Flock",
 	[OCFS2_LOCK_TYPE_QINFO] = "Quota",
+	[OCFS2_LOCK_TYPE_NFS_SYNC] = "NFSSync",
 	[OCFS2_LOCK_TYPE_ORPHAN_SCAN] = "OrphanScan",
 };
 
Signature · 1 line
1.6.0.2
#1 lore raw

PATCH 1/1 ocfs2: Add missing lock name

Quoted 21 lines · Jan Kara

There is missing name for NFSSync cluster lock. This makes lockdep unhappy because we end up passing NULL to lockdep when initializing lock key. Fix it.

---
 fs/ocfs2/ocfs2_lockid.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ocfs2/ocfs2_lockid.h +1 -0
index fcdba09..c212cf5 100644
@@ -108,6 +108,7 @@ static char *ocfs2_lock_type_strings[] = {
 	[OCFS2_LOCK_TYPE_OPEN] = "Open",
 	[OCFS2_LOCK_TYPE_FLOCK] = "Flock",
 	[OCFS2_LOCK_TYPE_QINFO] = "Quota",
+	[OCFS2_LOCK_TYPE_NFS_SYNC] = "NFSSync",
 	[OCFS2_LOCK_TYPE_ORPHAN_SCAN] = "OrphanScan",
 };
 
#2 lore raw

PATCH 1/1 ocfs2: Add missing lock name

In reply to Jan Kara
Quoted 2 lines · Jan Kara

There is missing name for NFSSync cluster lock. This makes lockdep unhappy because we end up passing NULL to lockdep when initializing lock key. Fix it.

This is now part of the fixes branch of ocfs2.git.

Joel

Signature · 9 lines
"Not everything that can be counted counts, and not everything
 that counts can be counted."
        - Albert Einstein 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127