compat.h required to build
Hi,
The following files:
/linux/drivers/media/dvb/frontends/stb6100.c
/linux/drivers/media/dvb/frontends/tda10021.c
/linux/drivers/media/dvb/frontends/ves1820.c
Fail to build with:
error: implicit declaration of function 'DIV_ROUND_CLOSEST'
and need the addition of:
#include "compat.h"
when building on my system. Is this related to my kernel version (2.6.28) or is it something else?
Thanks,
Lou
Quoted 10 lines · Lou Otway
Hi,
The following files:
/linux/drivers/media/dvb/frontends/stb6100.c
/linux/drivers/media/dvb/frontends/tda10021.c
/linux/drivers/media/dvb/frontends/ves1820.cFail to build with:
Quoted 8 lines
error: implicit declaration of function '
DIV_ROUND_CLOSEST'and need the addition of:
#include "
compat.h"when building on my system. Is this related to my kernel version (2.6.28) or is it something else?
DIV_ROUND_CLOSEST is probably available only in more recent kernels. When its use was added to those files, backward compatability was likely not tested. Including compat.h is the proper thing to do.
Regards,
Andy
Quoted 9 lines
Thanks,
Lou
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Andy Walls
DIV_ROUND_CLOSESTis probably available only in more recent kernels. When its use was added to those files, backward compatability was likely not tested. Includingcompat.his the proper thing to do.Regards,
Andy
I'm pretty sure Mauro just added the macro to compat.h yesterday (and I can only assume he missed a couple of includes). Lou, feel free to submit a patch with the extra includes, including an SOB.
Thanks,
Devin
Signature · 2 lines
Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com