sctp: fix check the chunk length of received HEARTBEAT-ACK
Subsystems (2)
PATCH 1/1 sctp: fix check the chunk length of received HEARTBEAT-ACK
The receiver of the HEARTBEAT should respond with a HEARTBEAT ACK that contains the Heartbeat Information field copied from the received HEARTBEAT chunk. So the received HEARTBEAT-ACK chunk must have a length of:
sizeof(sctp_chunkhdr_t) + sizeof(sctp_sender_hb_info_t)
A badly formatted HB-ACK chunk, it is possible that we may access invalid memory. We should really make sure that the chunk format is what we expect, before attempting to touch the data.
Signed-off-by Wei Yongjun <[email protected]>
--- net/sctp/sm_statefuns.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
net/sctp/sm_statefuns.c +2 -1
@@ -1106,7 +1106,8 @@ sctp_disposition_t sctp_sf_backbeat_8_3(const struct sctp_endpoint *ep,return sctp_sf_pdiscard (ep, asoc, type, arg, commands);/* Make sure that the HEARTBEAT-ACK chunk has a valid length. */ -if (!sctp_chunk_length_valid (chunk,sizeof (sctp_heartbeat_chunk_t))) +if (!sctp_chunk_length_valid (chunk,sizeof (sctp_chunkhdr_t) + +sizeof (sctp_sender_hb_info_t)))return sctp_sf_violation_chunklen (ep, asoc, type, arg, commands);
Signature · 1 line
1.6.2.2