Skip to contentSkip to conversation

drivers/net: use printk_once

PATCH RESEND Superseded Marcin Slusarz 1 participant 1 message Aug 23, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Marcin Slusarz

author
#0 lore raw

PATCH RESEND 1/1 drivers/net: use printk_once

From: Marcin Slusarz <[email protected]>
Subject: drivers/net: use printk_once

Signed-off-by Marcin Slusarz <[email protected]>
Acked-by David S. Miller <[email protected]>
Cc [email protected]
drivers/net/mlx4/en_main.c +1 -5
index 9ed4a15..18e9e4f 100644
@@ -151,15 +151,11 @@ static void mlx4_en_remove(struct mlx4_dev *dev, void *endev_ptr)
 
 static void *mlx4_en_add(struct mlx4_dev *dev)
 {
-	static int mlx4_en_version_printed;
 	struct mlx4_en_dev *mdev;
 	int i;
 	int err;
 
-	if (!mlx4_en_version_printed) {
-		printk(KERN_INFO "%s", mlx4_en_version);
-		mlx4_en_version_printed++;
-	}
+	printk_once(KERN_INFO "%s", mlx4_en_version);
 
 	mdev = kzalloc(sizeof *mdev, GFP_KERNEL);
 	if (!mdev) {
drivers/net/mv643xx_eth.c +1 -3
index 0f32db3..dbb1d9c 100644
@@ -2622,14 +2622,12 @@ static void infer_hw_params(struct mv643xx_eth_shared_private *msp)
 
 static int mv643xx_eth_shared_probe(struct platform_device *pdev)
 {
-	static int mv643xx_eth_version_printed;
 	struct mv643xx_eth_shared_platform_data *pd = pdev->dev.platform_data;
 	struct mv643xx_eth_shared_private *msp;
 	struct resource *res;
 	int ret;
 
-	if (!mv643xx_eth_version_printed++)
-		printk(KERN_NOTICE "MV-643xx 10/100/1000 ethernet "
+	printk_once(KERN_NOTICE "MV-643xx 10/100/1000 ethernet "
 			"driver version %s\n", mv643xx_eth_driver_version);
 
 	ret = -EINVAL;