nfs-utils: nfs-iostat.py option to sort by ops/s

PATCH In review Lans Carstensen 3 participants 5 messages Aug 25, 2009

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Lans Carstensen

author

2009-08-25 00:00 UTC #0 lore raw

PATCH 1/1 nfs-utils: nfs-iostat.py option to sort by ops/s

Hi,

I've recently made tools/nfs-iostat/nfs-iostat.py more useful in our autofs environment with a variety of cleanups and am offering this patch up for discussion and/or inclusion in nfs-utils. It does the following:

* Adds a --top flag to sort the display of mountpoint entries by ops/s.
* Adds a --<n> flag to only display stats for the first <n> mountpoints
* Re-reads the mountpoint list on intervals since it's dynamic in an autofs environment.
* Conforms the Python path to the LSB 3.2+ standard of /usr/bin/python
http://refspecs.freestandards.org/LSB_3.2.0/LSB-Languages/LSB-Languages/pylocation.html

My ml subscription is still pending, so make sure this email is cc'ed on feedback. Thank you.

-- Lans Carstensen

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +104 ~~-28~~

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/python
 # -*- python-mode -*-
 """Emulate iostat for NFS mount points using /proc/self/mountstats
 """

@@ -20,9 +20,9 @@
 Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 """
 
-import sys, os, time
+import sys, os, time, re
 
-Iostats_version = '0.2'
+Iostats_version = '0.3'
 
 def difference(x, y):
     """Used for a map() function

@@ -353,6 +353,13 @@
         print '\t%7.3f' % rtt_per_op,
         print '\t%7.3f' % exe_per_op
 
+    def ops(self, sample_time):
+        sends = float(self.__rpc_data['rpcsends'])
+        if sample_time == 0:
+            sample_time = float(self.__nfs_data['age'])
+        return (sends / sample_time)
+        
+
     def display_iostats(self, sample_time, which):
         """Display NFS and RPC stats in an iostat-like way
         """

@@ -421,6 +428,11 @@
     print ' If one or more <mount point> names are specified, statistics for only these'
     print ' mount points will be displayed.  Otherwise, all NFS mount points on the'
     print ' client are listed.'
+    print
+    print ' You can also specify "--top" to sort the NFS mount points by ops/second,'
+    print ' and specify a number of mount points to return with -<num>, e.g. -1.'
+    print ' For example, use of "--top -1" will iterate only showing you the stats'
+    print ' for the mount point with the largest ops/second.'
 
 def parse_stats_file(filename):
     """pop the contents of a mountstats file into a dictionary,

@@ -446,26 +458,82 @@
 
     return ms_dict
 
-def print_iostat_summary(old, new, devices, time, ac):
-    for device in devices:
+def print_iostat_summary(old, new, devices, time, ac, sortbyops, entrycount):
+    diff_stats = { }
+    count = 1
+
+    if old:
+        # Trim device list to only include intersection of old a new data,
+        # this addresses changes due to automount
+        devicelist = filter(lambda x:x in devices,old)
+    else:
+        devicelist = devices
+
+    for device in devicelist:
+        count += 1
         stats = DeviceData()
         stats.parse_stats(new[device])
         if not old:
             stats.display_iostats(time, ac)
+            if (count>entrycount):
+                return
         else:
             old_stats = DeviceData()
             old_stats.parse_stats(old[device])
-            diff_stats = stats.compare_iostats(old_stats)
-            diff_stats.display_iostats(time, ac)
+            diff_stats[device] = stats.compare_iostats(old_stats)
+            if not sortbyops:
+                diff_stats[device].display_iostats(time, ac)
+                if (count>entrycount):
+                    return
+
+    if old and sortbyops:
+        # We had old data and could formulate a comparison
+        # Now print comparison ordered by mountpoint ops per second
+        count = 1
+
+        devices.sort(key=lambda x: diff_stats[x].ops(time), reverse=True)
+
+        for device in devices:
+            count += 1
+            diff_stats[device].display_iostats(time, ac)
+            if (count>entrycount):
+                return
+
+def list_nfs_mounts(givenlist, mountstats):
+    """return a list of NFS mounts given a list to validate or
+       return a full list if the given list is empty
+    """
+    list = []
+    if len(givenlist) > 0:
+        for device in givenlist:
+            stats = DeviceData()
+            stats.parse_stats(mountstats[device])
+            if stats.is_nfs_mountpoint():
+                list += [device]
+    else:
+        for device, descr in mountstats.iteritems():
+            stats = DeviceData()
+            stats.parse_stats(descr)
+            if stats.is_nfs_mountpoint():
+                list += [device]
+    if len(list) == 0:
+        print 'No NFS mount points were found'
+        return
+   
+    return list
 
 def iostat_command(name):
     """iostat-like command for NFS mount points
     """
     mountstats = parse_stats_file('/proc/self/mountstats')
     devices = []
+    origdevices = []
     which = 0
     interval_seen = False
     count_seen = False
+    sortbyops = False
+    entrycount = sys.maxint
+
 
     for arg in sys.argv:
         if arg in ['-h', '--help', 'help', 'usage']:

@@ -476,6 +544,19 @@
             print '%s version %s' % (name, Iostats_version)
             return
 
+        if arg in ['-t', '--top', 'top']:
+            sortbyops = True
+            # top-like display infers a loop, default to 1 second
+            if not interval_seen:
+                interval = 1
+                interval_seen = True
+            continue
+
+        stop_re = re.compile('-[0-9]+')
+        if stop_re.match(arg):
+            entrycount = int(arg.lstrip('-'))
+            continue
+
         if arg in ['-a', '--attr']:
             which = 1
             continue

@@ -492,7 +573,7 @@
             continue
 
         if arg in mountstats:
-            devices += [arg]
+            origdevices += [arg]
         elif not interval_seen:
             interval = int(arg)
             if interval > 0:

@@ -509,47 +590,42 @@
                 return
 
     # make certain devices contains only NFS mount points
-    if len(devices) > 0:
-        check = []
-        for device in devices:
-            stats = DeviceData()
-            stats.parse_stats(mountstats[device])
-            if stats.is_nfs_mountpoint():
-                check += [device]
-        devices = check
-    else:
-        for device, descr in mountstats.iteritems():
-            stats = DeviceData()
-            stats.parse_stats(descr)
-            if stats.is_nfs_mountpoint():
-                devices += [device]
-    if len(devices) == 0:
-        print 'No NFS mount points were found'
-        return
+    devices = list_nfs_mounts(origdevices, mountstats)
 
     old_mountstats = None
     sample_time = 0.0
 
     if not interval_seen:
-        print_iostat_summary(old_mountstats, mountstats, devices, sample_time, which)
+        print_iostat_summary(old_mountstats, mountstats, devices, sample_time, which, sortbyops, entrycount)
         return
 
+
+    # Need to check for automount here and then use that flag below instead of always recalculating
+    
     if count_seen:
         while count != 0:
-            print_iostat_summary(old_mountstats, mountstats, devices, sample_time, which)
+            print_iostat_summary(old_mountstats, mountstats, devices, sample_time, which, sortbyops, entrycount)
             old_mountstats = mountstats
             time.sleep(interval)
             sample_time = interval
             mountstats = parse_stats_file('/proc/self/mountstats')
+
+            # automount mountpoints add and drop, if automount is involved we need to recheck the
+            # devices list when reiterating the check
+            devices = list_nfs_mounts(origdevices,mountstats)
+
             count -= 1
     else: 
         while True:
-            print_iostat_summary(old_mountstats, mountstats, devices, sample_time, which)
+            print_iostat_summary(old_mountstats, mountstats, devices, sample_time, which, sortbyops, entrycount)
             old_mountstats = mountstats
             time.sleep(interval)
             sample_time = interval
             mountstats = parse_stats_file('/proc/self/mountstats')
 
+            # automount mountpoints add and drop, if automount is involved we need to recheck the
+            # devices list when reiterating the check
+            devices = list_nfs_mounts(origdevices,mountstats)
 #
 # Main
 #

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that [email protected] is being discontinued. Please subscribe to [email protected] instead.
http://vger.kernel.org/vger-lists.html#linux-nfs

Chuck Lever

2009-08-25 17:08 UTC #1 lore raw

[ Cc: changed to correct mailing list. sf.net list is deprecated. ]

Quoted 10 lines · Lans Carstensen

Hi,
I've recently made tools/nfs-iostat/nfs-iostat.py more useful in our autofs environment with a variety of cleanups and am offering this patch up for discussion and/or inclusion in nfs-utils. It does the following:
* Adds a --top flag to sort the display of mountpoint entries by ops/s.
* Adds a --<n> flag to only display stats for the first <n> mountpoints
* Re-reads the mountpoint list on intervals since it's dynamic in an autofs environment.
* Conforms the Python path to the LSB 3.2+ standard of /usr/bin/python
http://refspecs.freestandards.org/LSB_3.2.0/LSB-Languages/LSB-Languages/pylocation.html

A couple of overall comments.

1. These seem to be logically independent changes, so we would prefer them in separate patches. Each logical change can be refined and voted up or down separately.

2. Sorting by ops is OK, but not sure about "--top". Since the script doesn't generate a curses like display like "top" does, maybe "--sort <n>" would be a better name, and --top and --<n> could be combined.

3. The distributors should weigh in on the Python path change.

4. I need to re-read the code to understand how the looping is done. Naturally we do want to keep up to date after a mount or umount occurs, but I thought it already did that. I'll try to apply the patch this afternoon and test it out.

Quoted 250 lines

My ml subscription is still pending, so make sure this email is cc'ed on feedback. Thank you.

-- Lans Carstensen
--- tools/nfs-iostat/nfs-iostat.py.orig 2009-08-24
15:52:26.000000000 -0700
+++ tools/nfs-iostat/nfs-iostat.py 2009-08-24 15:53:11.000000000 -0700

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +1 -1

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/python
 # -*- python-mode -*-

"""Emulate iostat for NFS mount points using /proc/self/mountstats """

(quoted diff) +0 -0

@@ -20,9 +20,9 @@

Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA """

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +2 -2

-import sys, os, time
+import sys, os, time, re
 
-Iostats_version = '0.2'
+Iostats_version = '0.3'

def difference(x, y):
"""Used for a map() function

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +7 -0

@@ -353,6 +353,13 @@
        print '\t%7.3f' % rtt_per_op,
        print '\t%7.3f' % exe_per_op
 
+    def ops(self, sample_time):
+        sends = float(self.__rpc_data['rpcsends'])
+        if sample_time == 0:
+            sample_time = float(self.__nfs_data['age'])
+        return (sends / sample_time)
+
+
    def display_iostats(self, sample_time, which):
        """Display NFS and RPC stats in an iostat-like way
        """

@@ -421,6 +428,11 @@
    print ' If one or more <mount point> names are specified,

statistics for only these'
print ' mount points will be displayed. Otherwise, all NFS
mount points on the'
print ' client are listed.'

(quoted diff) +2 -0

+    print
+    print ' You can also specify "--top" to sort the NFS mount

points by ops/second,'
+ print ' and specify a number of mount points to return with -
<num>, e.g. -1.'
+ print ' For example, use of "--top -1" will iterate only
showing you the stats'
+ print ' for the mount point with the largest ops/second.'

def parse_stats_file(filename):
"""pop the contents of a mountstats file into a dictionary,

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +1 -2

@@ -446,26 +458,82 @@
 
    return ms_dict
 
-def print_iostat_summary(old, new, devices, time, ac):
-    for device in devices:
+def print_iostat_summary(old, new, devices, time, ac, sortbyops,

entrycount):

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +5 -0

+    diff_stats = { }
+    count = 1
+
+    if old:
+        # Trim device list to only include intersection of old a

new data,

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +21 -2

+        # this addresses changes due to automount
+        devicelist = filter(lambda x:x in devices,old)
+    else:
+        devicelist = devices
+
+    for device in devicelist:
+        count += 1
        stats = DeviceData()
        stats.parse_stats(new[device])
        if not old:
            stats.display_iostats(time, ac)
+            if (count>entrycount):
+                return
        else:
            old_stats = DeviceData()
            old_stats.parse_stats(old[device])
-            diff_stats = stats.compare_iostats(old_stats)
-            diff_stats.display_iostats(time, ac)
+            diff_stats[device] = stats.compare_iostats(old_stats)
+            if not sortbyops:
+                diff_stats[device].display_iostats(time, ac)
+                if (count>entrycount):
+                    return
+
+    if old and sortbyops:
+        # We had old data and could formulate a comparison
+        # Now print comparison ordered by mountpoint ops per second
+        count = 1
+
+        devices.sort(key=lambda x: diff_stats[x].ops(time),

reverse=True)

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +29 -0

+
+        for device in devices:
+            count += 1
+            diff_stats[device].display_iostats(time, ac)
+            if (count>entrycount):
+                return
+
+def list_nfs_mounts(givenlist, mountstats):
+    """return a list of NFS mounts given a list to validate or
+       return a full list if the given list is empty
+    """
+    list = []
+    if len(givenlist) > 0:
+        for device in givenlist:
+            stats = DeviceData()
+            stats.parse_stats(mountstats[device])
+            if stats.is_nfs_mountpoint():
+                list += [device]
+    else:
+        for device, descr in mountstats.iteritems():
+            stats = DeviceData()
+            stats.parse_stats(descr)
+            if stats.is_nfs_mountpoint():
+                list += [device]
+    if len(list) == 0:
+        print 'No NFS mount points were found'
+        return
+
+    return list

def iostat_command(name):
"""iostat-like command for NFS mount points """
mountstats = parse_stats_file('/proc/self/mountstats') devices = []

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +22 ~~-19~~

+    origdevices = []
    which = 0
    interval_seen = False
    count_seen = False
+    sortbyops = False
+    entrycount = sys.maxint
+
 
    for arg in sys.argv:
        if arg in ['-h', '--help', 'help', 'usage']:

@@ -476,6 +544,19 @@
            print '%s version %s' % (name, Iostats_version)
            return
 
+        if arg in ['-t', '--top', 'top']:
+            sortbyops = True
+            # top-like display infers a loop, default to 1 second
+            if not interval_seen:
+                interval = 1
+                interval_seen = True
+            continue
+
+        stop_re = re.compile('-[0-9]+')
+        if stop_re.match(arg):
+            entrycount = int(arg.lstrip('-'))
+            continue
+
        if arg in ['-a', '--attr']:
            which = 1
            continue

@@ -492,7 +573,7 @@
            continue
 
        if arg in mountstats:
-            devices += [arg]
+            origdevices += [arg]
        elif not interval_seen:
            interval = int(arg)
            if interval > 0:

@@ -509,47 +590,42 @@
                return
 
    # make certain devices contains only NFS mount points
-    if len(devices) > 0:
-        check = []
-        for device in devices:
-            stats = DeviceData()
-            stats.parse_stats(mountstats[device])
-            if stats.is_nfs_mountpoint():
-                check += [device]
-        devices = check
-    else:
-        for device, descr in mountstats.iteritems():
-            stats = DeviceData()
-            stats.parse_stats(descr)
-            if stats.is_nfs_mountpoint():
-                devices += [device]
-    if len(devices) == 0:
-        print 'No NFS mount points were found'
-        return
+    devices = list_nfs_mounts(origdevices, mountstats)
 
    old_mountstats = None
    sample_time = 0.0
 
    if not interval_seen:
-        print_iostat_summary(old_mountstats, mountstats, devices,  
 sample_time, which)
+        print_iostat_summary(old_mountstats, mountstats, devices,  
 sample_time, which, sortbyops, entrycount)
        return
 
+
+    # Need to check for automount here and then use that flag below

instead of always recalculating

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +1 -1

+
    if count_seen:
        while count != 0:
-            print_iostat_summary(old_mountstats, mountstats,

devices, sample_time, which)
+ print_iostat_summary(old_mountstats, mountstats,
devices, sample_time, which, sortbyops, entrycount)
old_mountstats = mountstats time.sleep(interval)
sample_time = interval
mountstats = parse_stats_file('/proc/self/mountstats')

(quoted diff) +2 -0

+
+            # automount mountpoints add and drop, if automount is

involved we need to recheck the

nfs-iostat/nfs-iostat.py renamed from nfs-iostat/nfs-iostat.py.orig +3 -1

+            # devices list when reiterating the check
+            devices = list_nfs_mounts(origdevices,mountstats)
+
            count -= 1
    else:
        while True:
-            print_iostat_summary(old_mountstats, mountstats,

+ # automount mountpoints add and drop, if automount is
involved we need to recheck the

(quoted diff) +2 -0

+            # devices list when reiterating the check
+            devices = list_nfs_mounts(origdevices,mountstats)

#
# Main
#
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on

Quoted 8 lines

what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that [email protected] is being discontinued.
Please subscribe to [email protected] instead.
http://vger.kernel.org/vger-lists.html#linux-nfs

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Steve Dickson

2009-08-25 17:34 UTC #2 lore raw

Quoted 18 lines · Chuck Lever

[ Cc: changed to correct mailing list. sf.net list is deprecated. ]
Quoted 7 lines · Lans Carstensen
Hi,
I've recently made tools/nfs-iostat/nfs-iostat.py more useful in our autofs environment with a variety of cleanups and am offering this patch up for discussion and/or inclusion in nfs-utils. It does the following:
Quoted 7 lines
* Adds a --top flag to sort the display of mountpoint entries by ops/s.
* Adds a --<n> flag to only display stats for the first <n> mountpoints
* Re-reads the mountpoint list on intervals since it's dynamic in an autofs environment.
* Conforms the Python path to the LSB 3.2+ standard of /usr/bin/python
http://refspecs.freestandards.org/LSB_3.2.0/LSB-Languages/LSB-Languages/pylocation.html

Quoted 5 lines

A couple of overall comments.
1. These seem to be logically independent changes, so we would prefer them in separate patches. Each logical change can be refined and voted up or down separately.

I guess you could break this up into more patches... but overall its by no means unruly....

Quoted 4 lines

2. Sorting by ops is OK, but not sure about "--top". Since the script doesn't generate a curses like display like "top" does, maybe "--sort <n>" would be a better name, and --top and --<n> could be combined.

Hmm.. I kinda like like the --top flag... its pretty descriptive to what it does..

Quoted 2 lines

3. The distributors should weigh in on the Python path change.

Using '#!/usr/bin/python' is better than '#!/usr/bin/env python' since you know exactly which python binary you will be using. It was also pointed out the env convention will confuse rpm's dependency generator

steved.

Chuck Lever

2009-08-25 17:49 UTC #3 lore raw

Quoted 19 lines · Steve Dickson

Quoted 18 lines · Chuck Lever
[ Cc: changed to correct mailing list. sf.net list is deprecated. ]
Quoted 14 lines · Lans Carstensen
Hi,
I've recently made tools/nfs-iostat/nfs-iostat.py more useful in our autofs environment with a variety of cleanups and am offering this patch up for discussion and/or inclusion in nfs-utils. It does the following:
* Adds a --top flag to sort the display of mountpoint entries by ops/s.
* Adds a --<n> flag to only display stats for the first <n> mountpoints
* Re-reads the mountpoint list on intervals since it's dynamic in an autofs environment.
* Conforms the Python path to the LSB 3.2+ standard of /usr/bin/python
http://refspecs.freestandards.org/LSB_3.2.0/LSB-Languages/LSB-Languages/pylocation.html

Quoted 7 lines

Quoted 5 lines
A couple of overall comments.
1. These seem to be logically independent changes, so we would prefer them in separate patches. Each logical change can be refined and voted up or down separately.
I guess you could break this up into more patches... but overall its by no means unruly....

Didn't mean to imply "unruly" but we do _prefer_ having logical changes separated.

Quoted 5 lines

Quoted 3 lines
2. Sorting by ops is OK, but not sure about "--top". Since the script doesn't generate a curses like display like "top" does, maybe "--sort <n>" would be a better name, and --top and --<n> could be combined.
Hmm.. I kinda like like the --top flag... its pretty descriptive to what it does..

Some people aren't so imaginative, might expect "--top" to produce a full curses-like display, then be pissed when they get a simple list. And it seems to me that the two new options are related and could be combined to good effect.

I think "--top" should be reserved for an actual top-like implementation (which might be pretty cool).

Quoted 5 lines

Quoted 1 line
3. The distributors should weigh in on the Python path change.
Using '#!/usr/bin/python' is better than '#!/usr/bin/env python' since you know exactly which python binary you will be using. It was also pointed out the env convention will confuse rpm's dependency generator

Good enough for me. Lans, it would be nice to document this last bit (about rpm) in the patch description.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Lans Carstensen

author

2009-08-25 18:56 UTC #4 lore raw

Quoted 41 lines · Chuck Lever

Quoted 20 lines · Steve Dickson
Quoted 19 lines · Chuck Lever
[ Cc: changed to correct mailing list. sf.net list is deprecated. ]
Quoted 15 lines · Lans Carstensen
Hi,
I've recently made tools/nfs-iostat/nfs-iostat.py more useful in our autofs environment with a variety of cleanups and am offering this patch up for discussion and/or inclusion in nfs-utils. It does the following:
* Adds a --top flag to sort the display of mountpoint entries by ops/s.
* Adds a --<n> flag to only display stats for the first <n> mountpoints
* Re-reads the mountpoint list on intervals since it's dynamic in an autofs environment.
* Conforms the Python path to the LSB 3.2+ standard of /usr/bin/python
http://refspecs.freestandards.org/LSB_3.2.0/LSB-Languages/LSB-Languages/pylocation.html
Quoted 7 lines
Quoted 5 lines
A couple of overall comments.
1. These seem to be logically independent changes, so we would prefer them in separate patches. Each logical change can be refined and voted up or down separately.
I guess you could break this up into more patches... but overall its by no means unruly....
Didn't mean to imply "unruly" but we do _prefer_ having logical changes separated.
Quoted 5 lines
Quoted 3 lines
2. Sorting by ops is OK, but not sure about "--top". Since the script doesn't generate a curses like display like "top" does, maybe "--sort <n>" would be a better name, and --top and --<n> could be combined.
Hmm.. I kinda like like the --top flag... its pretty descriptive to what it does..
Some people aren't so imaginative, might expect "--top" to produce a full curses-like display, then be pissed when they get a simple list. And it seems to me that the two new options are related and could be combined to good effect.
I think "--top" should be reserved for an actual top-like implementation (which might be pretty cool).

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
3. The distributors should weigh in on the Python path change.
Using '#!/usr/bin/python' is better than '#!/usr/bin/env python' since you know exactly which python binary you will be using. It was also pointed out the env convention will confuse rpm's dependency generator
Good enough for me. Lans, it would be nice to document this last bit (about rpm) in the patch description.

Thanks for looking at this, guys.

* I don't live in git, so it'll take me a little bit to break out the patches - but I certainly don't mind if that helps this along.

* To aid your testing on rescanning, there is a rescan but currently no handling of differences in the "new" and "old" mount table and there is no re-evaluation of the list of monitored mountpoints based on changes in the mount table. The existing implementation will throw a Python exception when a mountpoint (say a user homedirectory) is unmounted from a system during a trace. The displayed data is also misleading if the list of monitored mountpoints isn't grown to reflect new automounts that might be your current top talkers.

* "--sort" doesn't offend me and I can switch to that. The semantic of "--top -1" was the most intuitive for a couple of us here but "--sort -1" isn't that far off.

* I agree a real "top" implementation would be cool.

-- Lans