nfs-utils: nfs-iostat.py autofs cleanup and option to sort by ops/s

PATCH In review Lans Carstensen 3 participants 9 messages Aug 26, 2009 – Aug 27, 2009

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Lans Carstensen

author

2009-08-26 04:59 UTC #0 lore raw

PATCH 2/4 nfs-utils: nfs-iostat.py autofs cleanup and option to sort by ops/s

commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e

Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700

Bump nfs-iostat.py version up to 0.3 to reflect new features.

tools/nfs-iostat/nfs-iostat.py +1 -1

index ea02db4..6ce31fc 100644
@@ -22,7 +22,7 @@ Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 
 import sys, os, time
 
-Iostats_version = '0.2'
+Iostats_version = '0.3'
 
 def difference(x, y):
     """Used for a map() function

Chuck Lever

2009-08-26 14:28 UTC #1 lore raw

Quoted 5 lines · Lans Carstensen

commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700
Bump nfs-iostat.py version up to 0.3 to reflect new features.

Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?

Quoted 12 lines

tools/nfs-iostat/nfs-iostat.py +0 -0
index ea02db4..6ce31fc 100644
@@ -22,7 +22,7 @@ Foundation, Inc., 59 Temple Place, Suite 330,  
Boston, MA 02111-1307 USA
import sys, os, time
tools/nfs-iostat/nfs-iostat.py +1 -1
-Iostats_version = '0.2'
+Iostats_version = '0.3'

Quoted 8 lines

def difference(x, y):
"""Used for a map() function
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Steve Dickson

2009-08-26 15:13 UTC #2 lore raw

Quoted 7 lines · Chuck Lever

Quoted 4 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700

Quoted 6 lines

Quoted 1 line
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?

Hmm... I don't think we tie any of other commands versions to the package version.... Although it might be a good idea to do so, but for this instance, since these commands are still incognito (there are not man pages, which is on my plate), I think just bumping the version is fine..

steved.

Chuck Lever

2009-08-26 15:35 UTC #3 lore raw

Quoted 8 lines · Steve Dickson

Quoted 7 lines · Chuck Lever
Quoted 4 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?
Hmm... I don't think we tie any of other commands versions to the package version....

Actually many of the C commands do grab a macro defined during autoconfiguration: PACKAGE_VERSION.

Quoted 6 lines

Although it might be a good idea to do so,
but for this instance, since these commands are still incognito (there are not man pages, which is on my plate), I think just bumping the version is fine..
steved.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Steve Dickson

2009-08-26 18:03 UTC #4 lore raw

Quoted 15 lines · Chuck Lever

Quoted 14 lines · Steve Dickson
Quoted 13 lines · Chuck Lever
Quoted 5 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?

Quoted 6 lines

Quoted 2 lines
Hmm... I don't think we tie any of other commands versions to the package version....
Actually many of the C commands do grab a macro defined during
autoconfiguration: PACKAGE_VERSION.

Interesting.. I do see PACKAGE_VERSION being defined in support/include/config.h I guess I didn't know that was there and it does not seem to be used by anybody... which is probably a problem but I don't think its a problem with this script...

steved.

Chuck Lever

2009-08-26 20:29 UTC #5 lore raw

Quoted 19 lines · Steve Dickson

Quoted 18 lines · Chuck Lever
Quoted 16 lines · Steve Dickson
Quoted 7 lines · Chuck Lever
Quoted 4 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700
Quoted 6 lines
Quoted 1 line
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?
Hmm... I don't think we tie any of other commands versions to the package version....

Quoted 7 lines

Quoted 3 lines
Actually many of the C commands do grab a macro defined during
autoconfiguration: PACKAGE_VERSION.
Interesting.. I do see PACKAGE_VERSION being defined in support/include/config.h I guess I didn't know that was there and it does not seem to be used by anybody... which is probably a problem but I don't think its a problem with this script...

Right, I'm suggesting now would be a good time to switch these scripts over to the package-wide versioning scheme.

But take a look at mount, statd, showmount, and nfsstat, at least: these, for example, use the VERSION macro in their -V and usage messages.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Lans Carstensen

author

2009-08-26 23:56 UTC #6 lore raw

Quoted 23 lines · Chuck Lever

Quoted 22 lines · Steve Dickson
Quoted 21 lines · Chuck Lever
Quoted 8 lines · Steve Dickson
Quoted 7 lines · Chuck Lever
Quoted 4 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?
Hmm... I don't think we tie any of other commands versions to the package version....
Actually many of the C commands do grab a macro defined during
autoconfiguration: PACKAGE_VERSION.

Quoted 8 lines

Quoted 4 lines
Interesting.. I do see PACKAGE_VERSION being defined in support/include/config.h I guess I didn't know that was there and it does not seem to be used by anybody... which is probably a problem but I don't think its a problem with this script...
Right, I'm suggesting now would be a good time to switch these scripts over to the package-wide versioning scheme.
But take a look at mount, statd, showmount, and nfsstat, at least: these, for example, use the VERSION macro in their -V and usage messages.

I agree with that concept but I'll kindly defer on the implementation as I'm not exactly sure what would be required. I guess maybe generation of a Makefile.am that uses sed or somesuch to patch the script?

-- Lans Carstensen, Systems Engineering, Dreamworks Animation Because they consistently observe and listen, the humble improve.
-- Wynton Marsalis

Chuck Lever

2009-08-27 14:05 UTC #7 lore raw

Quoted 24 lines · Lans Carstensen

Quoted 23 lines · Chuck Lever
Quoted 22 lines · Steve Dickson
Quoted 21 lines · Chuck Lever
Quoted 8 lines · Steve Dickson
Quoted 7 lines · Chuck Lever
Quoted 4 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?
Hmm... I don't think we tie any of other commands versions to the package version....
Actually many of the C commands do grab a macro defined during
autoconfiguration: PACKAGE_VERSION.

Quoted 8 lines

Quoted 6 lines
Quoted 4 lines
Interesting.. I do see PACKAGE_VERSION being defined in support/include/config.h I guess I didn't know that was there and it does not seem to be used by anybody... which is probably a problem but I don't think its a problem with this script...
Right, I'm suggesting now would be a good time to switch these scripts over to the package-wide versioning scheme.
But take a look at mount, statd, showmount, and nfsstat, at least: these, for example, use the VERSION macro in their -V and usage messages.
I agree with that concept but I'll kindly defer on the implementation as I'm not exactly sure what would be required.

That's quite alright. Probably Steve should cook something up for this one.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Steve Dickson

2009-08-27 14:17 UTC #8 lore raw

Quoted 38 lines · Chuck Lever

Quoted 37 lines · Lans Carstensen
Quoted 35 lines · Chuck Lever
Quoted 23 lines · Steve Dickson
Quoted 16 lines · Chuck Lever
Quoted 15 lines · Steve Dickson
Quoted 14 lines · Chuck Lever
Quoted 5 lines · Lans Carstensen
commit d3bb692a8c26c2d4e0dc70d7d0359daf79090e1e
Author: Lans Carstensen <[email protected]>
Date:   Tue Aug 25 21:52:03 2009 -0700
Bump nfs-iostat.py version up to 0.3 to reflect new features.
Now that nfs-iostat.py has been integrated into nfs-utils, I'm not sure
we want to maintain an individual version number for it. Maybe it should use the nfs-utils package's versioning instead... Steve, your thoughts?
Quoted 6 lines
Quoted 2 lines
Hmm... I don't think we tie any of other commands versions to the package version....
Actually many of the C commands do grab a macro defined during
autoconfiguration: PACKAGE_VERSION.
Quoted 6 lines
Interesting.. I do see PACKAGE_VERSION being defined in support/include/config.h
I guess I didn't know that was there and it does not seem to be used by anybody... which is probably a problem but I don't think its a problem
with this script...
Right, I'm suggesting now would be a good time to switch these scripts over to the package-wide versioning scheme.
But take a look at mount, statd, showmount, and nfsstat, at least:
these, for example, use the VERSION macro in their -V and usage messages.

Quoted 5 lines

Quoted 2 lines
I agree with that concept but I'll kindly defer on the implementation as I'm not exactly sure what would be required.
That's quite alright. Probably Steve should cook something up for this one.

Yeah... don't get get hung up on this one... I'll deal with it...

steved.