Skip to contentSkip to conversation

linux-nokia800-2.6.21-osso71.bb fixed undefined reference to __aeabi_uldivmod problem when using gcc-4.3 compile linux-nokia800-2.6.21-osso71

PATCH In review Ming Chow 周明 2 participants 3 messages Aug 20, 2009 – Aug 27, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 linux-nokia800-2.6.21-osso71.bb fixed undefined reference to __aeabi_uldivmod problem when using gcc-4.3 compile linux-nokia800-2.6.21-osso71

From bc8990dbee051e9f36a2b90761ce1f405f8dabc6 Mon Sep 17 00:00:00 2001
From: Ming Zhou <[email protected]>
Date: Fri, 21 Aug 2009 02:04:15 +0800
Subject: [PATCH] linux-nokia800-2.6.21-osso71.bb fixed undefined reference to __aeabi_uldivmod problem when using gcc-4.3 compile linux-nokia800-2.6.21-osso71

---
...x-gcc-4.3-false-modulo-optimization.patch.patch | 48 ++++++++++++++++++++
recipes/linux/linux-nokia800_2.6.21-osso71.bb | 1 +

2 files changed, 49 insertions(+), 0 deletions(-)

create mode 100644 recipes/linux/linux-nokia800-2.6.21-osso71/1300-fix-gcc-4.3-false-modulo-optimization.patch.patch

recipes/linux/linux-nokia800-2.6.21-osso71/1300-fix-gcc-4.3-false-modulo-optimization.patch.patch new file +48 -0
new file mode 100644
index 0000000..3ff0c07
@@ -0,0 +1,48 @@
+From f5b973489beb1a1239dfad53e3ad6e36ff7ee958 Mon Sep 17 00:00:00 2001
+From: Segher Boessenkool <[email protected]>
+Date: Thu, 9 Oct 2008 21:18:27 +0100
+Subject: [PATCH] fix-gcc-4.3-false-modulo-optimization.patch
+
+I tried to compile the current stable kernel
+(a2ef813d2f439a3e9f377d33a2e5baad098afb7e)
+and get the following errors:
+
+kernel/built-in.o: In function `timespec_add_ns':
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:174:
+undefined reference to `__aeabi_uldivmod'
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:179:
+undefined reference to `__aeabi_uldivmod'
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:174:
+undefined reference to `__aeabi_uldivmod'
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:179:
+undefined reference to `__aeabi_uldivmod'
+
+applying the following patch solved the problem:
+--------
+Prevent gcc-4.3 form "optimizing" the while loop into a costly modulo operation.
+Patch found at http://lkml.org/lkml/2008/2/22/464.
+
+Reported-by: Sven Rebhan <[email protected]>
+Signed-off-by: Segher Boessenkool <[email protected]>
+---
+ include/linux/time.h |    4 ++++
+ 1 files changed, 4 insertions(+), 0 deletions(-)
+
+diff --git a/include/linux/time.h b/include/linux/time.h
+index b04136d..3e8fd9e 100644
+--- a/include/linux/time.h
++++ b/include/linux/time.h
+@@ -173,6 +173,10 @@ static inline void timespec_add_ns(struct timespec *a, u64 ns)
+ {
+     ns += a->tv_nsec;
+     while(unlikely(ns >= NSEC_PER_SEC)) {
++        /* The following asm() prevents the compiler from
++         * optimising this loop into a modulo operation.  */
++        asm("" : "+r"(ns));
++
+         ns -= NSEC_PER_SEC;
+         a->tv_sec++;
+     }
+--
+1.5.6.5
+
recipes/linux/linux-nokia800_2.6.21-osso71.bb +0 -0
index 1ac4cf1..388df4f 100644
@@ -8,6 +8,7 @@ SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-2.6.21.tar.bz2 \
           
http://www.rpsys.net/openzaurus/patches/archive/input_power-r7.patch;patch=1 \
       file://suspend-button.patch;patch=1 \
           file://linux-2.6-limits.patch;patch=1 \

+ file://1300-fix-gcc-4.3-false-modulo-optimization.patch.patch;patch=1 \
file://defconfig"

S = "${WORKDIR}/linux-2.6.21"

Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 6 lines · On Thursday 20 August 2009 20:10:42 Ming Chow 周明 wrote:

From bc8990dbee051e9f36a2b90761ce1f405f8dabc6 Mon Sep 17 00:00:00 2001
From: Ming Zhou <[email protected]>
Date: Fri, 21 Aug 2009 02:04:15 +0800
Subject: [PATCH] linux-nokia800-2.6.21-osso71.bb fixed undefined reference to __aeabi_uldivmod problem when using gcc-4.3 compile linux-nokia800-2.6.21-osso71

http://patchwork.openembedded.org/patch/975/

Your mailer created a total mess, could you attempt to fix that?

#2 lore raw

Sure. Thank you.

Quoted 14 lines · Holger Hans Peter Freyther
Quoted 7 lines · On Thursday 20 August 2009 20:10:42 Ming Chow 周明 wrote:

From bc8990dbee051e9f36a2b90761ce1f405f8dabc6 Mon Sep 17 00:00:00 2001
From: Ming Zhou <[email protected]>
Date: Fri, 21 Aug 2009 02:04:15 +0800
Subject: [PATCH] linux-nokia800-2.6.21-osso71.bb fixed undefined reference to __aeabi_uldivmod problem when using gcc-4.3 compile linux-nokia800-2.6.21-osso71

http://patchwork.openembedded.org/patch/975/

Quoted 7 lines

Your mailer created a total mess, could you attempt to fix that?

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

From bc8990dbee051e9f36a2b90761ce1f405f8dabc6 Mon Sep 17 00:00:00 2001
From: Ming Zhou <[email protected]>
Date: Fri, 21 Aug 2009 02:04:15 +0800
Subject: [PATCH] linux-nokia800_2.6.21-osso71.bb fixed undefined reference to __aeabi_uldivmod problem when using gcc-4.3 compile linux-nokia800-2.6.21-osso71

---
 ...x-gcc-4.3-false-modulo-optimization.patch.patch |   48 ++++++++++++++++++++
 recipes/linux/linux-nokia800_2.6.21-osso71.bb      |    1 +
 2 files changed, 49 insertions(+), 0 deletions(-)
 create mode 100644 recipes/linux/linux-nokia800-2.6.21-osso71/1300-fix-gcc-4.3-false-modulo-optimization.patch.patch
recipes/linux/linux-nokia800-2.6.21-osso71/1300-fix-gcc-4.3-false-modulo-optimization.patch.patch new file +48 -0
new file mode 100644
index 0000000..3ff0c07
@@ -0,0 +1,48 @@
+From f5b973489beb1a1239dfad53e3ad6e36ff7ee958 Mon Sep 17 00:00:00 2001
+From: Segher Boessenkool <[email protected]>
+Date: Thu, 9 Oct 2008 21:18:27 +0100
+Subject: [PATCH] fix-gcc-4.3-false-modulo-optimization.patch
+
+I tried to compile the current stable kernel
+(a2ef813d2f439a3e9f377d33a2e5baad098afb7e)
+and get the following errors:
+
+kernel/built-in.o: In function `timespec_add_ns':
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:174:
+undefined reference to `__aeabi_uldivmod'
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:179:
+undefined reference to `__aeabi_uldivmod'
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:174:
+undefined reference to `__aeabi_uldivmod'
+/mnt/data/Freerunner/Gentoo/rootinstall/usr/src/linux/include/linux/time.h:179:
+undefined reference to `__aeabi_uldivmod'
+
+applying the following patch solved the problem:
+--------
+Prevent gcc-4.3 form "optimizing" the while loop into a costly modulo operation.
+Patch found at http://lkml.org/lkml/2008/2/22/464.
+
+Reported-by: Sven Rebhan <[email protected]>
+Signed-off-by: Segher Boessenkool <[email protected]>
+---
+ include/linux/time.h |    4 ++++
+ 1 files changed, 4 insertions(+), 0 deletions(-)
+
+diff --git a/include/linux/time.h b/include/linux/time.h
+index b04136d..3e8fd9e 100644
+--- a/include/linux/time.h
++++ b/include/linux/time.h
+@@ -173,6 +173,10 @@ static inline void timespec_add_ns(struct timespec *a, u64 ns)
+ {
+ 	ns += a->tv_nsec;
+ 	while(unlikely(ns >= NSEC_PER_SEC)) {
++		/* The following asm() prevents the compiler from
++		 * optimising this loop into a modulo operation.  */
++		asm("" : "+r"(ns));
++
+ 		ns -= NSEC_PER_SEC;
+ 		a->tv_sec++;
+ 	}
+-- 
+1.5.6.5
+
recipes/linux/linux-nokia800_2.6.21-osso71.bb +1 -0
index 1ac4cf1..388df4f 100644
@@ -8,6 +8,7 @@ SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-2.6.21.tar.bz2 \
            http://www.rpsys.net/openzaurus/patches/archive/input_power-r7.patch;patch=1 \
 	   file://suspend-button.patch;patch=1 \
            file://linux-2.6-limits.patch;patch=1 \
+           file://1300-fix-gcc-4.3-false-modulo-optimization.patch.patch;patch=1 \
 	   file://defconfig"
 
 S = "${WORKDIR}/linux-2.6.21"
Signature · 1 line
1.5.4.3