can: use correct NET_RX_ return values

PATCH Applied Oliver Hartkopp 2 participants 2 messages Aug 29, 2009 – Aug 31, 2009

Subsystems (3)

Networking Network drivers CAN network layer

lore

Share & tools

lore

Oliver Hartkopp

author

2009-08-29 16:45 UTC #0 lore raw

PATCH 1/1 can: use correct NET_RX_ return values

Dropped skb's should be documented by an appropriate return value. Use the correct NET_RX_DROP and NET_RX_SUCCESS values for that reason.

Signed-off-by Oliver Hartkopp <[email protected]>

---

net/can/af_can.c +2 -2

index f9c027b..ef1c43a 100644
@@ -686,11 +686,11 @@ static int can_rcv(struct sk_buff *skb, struct net_device *dev,
 		can_stats.matches_delta++;
 	}
 
-	return 0;
+	return NET_RX_SUCCESS;
 
 drop:
 	kfree_skb(skb);
-	return 0;
+	return NET_RX_DROP;
 }
 
 /*

David Miller

maintainer Applied

2009-08-31 05:13 UTC #1 lore raw

From: Oliver Hartkopp <[email protected]>
Date: Sat, 29 Aug 2009 18:45:09 +0200

Quoted 4 lines

Dropped skb's should be documented by an appropriate return value. Use the correct NET_RX_DROP and NET_RX_SUCCESS values for that reason.
Signed-off-by Oliver Hartkopp <[email protected]>

Applied, thanks.