Skip to contentSkip to conversation

Make git status print a helpful death message if the disk is full

PATCH New David Reiss 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

David Reiss

author
#0 lore raw

PATCH v2 1/1 Make git status print a helpful death message if the disk is full

The old behavior just said that it failed. Now it includes the error information, which makes it much easier to debug.

There is a risk that some failure paths could result in misleading error messages that actually make debugging more difficult.

Signed-off-by David Reiss <[email protected]>

---
Sorry I missed that.

 builtin-commit.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
builtin-commit.c +3 -3
index 4bcce06..7feb598 100644
@@ -256,7 +256,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
 		refresh_cache(REFRESH_QUIET);
 		if (write_cache(fd, active_cache, active_nr) ||
 		    close_lock_file(&index_lock))
-			die("unable to write new_index file");
+			die_errno("unable to write new_index file");
 		commit_style = COMMIT_NORMAL;
 		return index_lock.filename;
 	}

@@ -275,7 +275,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
 		refresh_cache(REFRESH_QUIET);
 		if (write_cache(fd, active_cache, active_nr) ||
 		    commit_locked_index(&index_lock))
-			die("unable to write new_index file");
+			die_errno("unable to write new_index file");
 		commit_style = COMMIT_AS_IS;
 		return get_index_file();
 	}

@@ -318,7 +318,7 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
 	refresh_cache(REFRESH_QUIET);
 	if (write_cache(fd, active_cache, active_nr) ||
 	    close_lock_file(&index_lock))
-		die("unable to write new_index file");
+		die_errno("unable to write new_index file");
 
 	fd = hold_lock_file_for_update(&false_lock,
 				       git_path("next-index-%"PRIuMAX,
Signature · 1 line
1.6.0.4