locomo.c: CodingStyle cleanups
PATCH 1/1 locomo.c: CodingStyle cleanups
EXPORT* macros should follow immediately after the closing function brace line.
The prototype for locomo_chip_driver() is not needed since the static (inline) function is located earlier in the file.
---
I originally sent this to the wrong list...
arch/arm/common/locomo.c +7 -10
@@ -865,6 +865,7 @@ void locomo_gpio_set_dir(struct device *dev, unsigned int bits, unsigned int dirspin_unlock_irqrestore (&lchip->lock, flags); } +EXPORT_SYMBOL (locomo_gpio_set_dir);int locomo_gpio_read_level (struct device *dev,unsigned int bits) {
@@ -882,6 +883,7 @@ int locomo_gpio_read_level(struct device *dev, unsigned int bits) ret &= bits;return ret; } +EXPORT_SYMBOL (locomo_gpio_read_level);int locomo_gpio_read_output (struct device *dev,unsigned int bits) {
@@ -899,6 +901,7 @@ int locomo_gpio_read_output(struct device *dev, unsigned int bits) ret &= bits;return ret; } +EXPORT_SYMBOL (locomo_gpio_read_output);void locomo_gpio_write (struct device *dev,unsigned int bits,unsigned int set) {
@@ -920,6 +923,7 @@ void locomo_gpio_write(struct device *dev, unsigned int bits, unsigned int set)spin_unlock_irqrestore (&lchip->lock, flags); } +EXPORT_SYMBOL (locomo_gpio_write);static void locomo_m62332_sendbit (void *mapbase,int bit) {
@@ -1084,13 +1088,12 @@ void locomo_m62332_senddata(struct locomo_dev *ldev, unsigned int dac_data, intspin_unlock_irqrestore (&lchip->lock, flags); } +EXPORT_SYMBOL (locomo_m62332_senddata);/* * Frontlight control */ -static struct locomo *locomo_chip_driver (struct locomo_dev *ldev); -void locomo_frontlight_set (struct locomo_dev *dev,int duty,int vr,int bpwf) {unsigned long flags;
@@ -1182,11 +1185,13 @@ int locomo_driver_register(struct locomo_driver *driver) driver->drv.bus = &locomo_bus_type;return driver_register (&driver->drv); } +EXPORT_SYMBOL (locomo_driver_register);void locomo_driver_unregister (struct locomo_driver *driver) {driver_unregister (&driver->drv); } +EXPORT_SYMBOL (locomo_driver_unregister);static int __init locomo_init (void ) {
@@ -1208,11 +1213,3 @@ module_exit(locomo_exit);MODULE_DESCRIPTION ("Sharp LoCoMo core driver" );MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("John Lenz <[email protected]>" ); - -EXPORT_SYMBOL (locomo_driver_register); -EXPORT_SYMBOL (locomo_driver_unregister); -EXPORT_SYMBOL (locomo_gpio_set_dir); -EXPORT_SYMBOL (locomo_gpio_read_level); -EXPORT_SYMBOL (locomo_gpio_read_output); -EXPORT_SYMBOL (locomo_gpio_write); -EXPORT_SYMBOL (locomo_m62332_senddata);
PATCH 1/1 locomo.c: CodingStyle cleanups
Quoted 9 lines · H Hartley Sweeten
EXPORT* macros should follow immediately after the closing function brace line.
The prototype for
locomo_chip_driver()is not needed since the static (inline) function is located earlier in the file.Signed-off-by H Hartley Sweeten <[email protected]>Cc John Lenz <[email protected]>
Patch looks ok, although I am no longer active in linux development. Patch should be sent to Pavel.
Quoted 82 lines
---
I originally sent this to the wrong list...
arch/arm/common/locomo.c +7
-10@@ -865,6 +865,7 @@ void locomo_gpio_set_dir(struct device *dev, unsigned int bits, unsigned int dirspin_unlock_irqrestore (&lchip->lock, flags); } +EXPORT_SYMBOL (locomo_gpio_set_dir);int locomo_gpio_read_level (struct device *dev,unsigned int bits) {@@ -882,6 +883,7 @@ int locomo_gpio_read_level(struct device *dev, unsigned int bits) ret &= bits;return ret; } +EXPORT_SYMBOL (locomo_gpio_read_level);int locomo_gpio_read_output (struct device *dev,unsigned int bits) {@@ -899,6 +901,7 @@ int locomo_gpio_read_output(struct device *dev, unsigned int bits) ret &= bits;return ret; } +EXPORT_SYMBOL (locomo_gpio_read_output);void locomo_gpio_write (struct device *dev,unsigned int bits,unsigned int set) {@@ -920,6 +923,7 @@ void locomo_gpio_write(struct device *dev, unsigned int bits, unsigned int set)spin_unlock_irqrestore (&lchip->lock, flags); } +EXPORT_SYMBOL (locomo_gpio_write);static void locomo_m62332_sendbit (void *mapbase,int bit) {@@ -1084,13 +1088,12 @@ void locomo_m62332_senddata(struct locomo_dev *ldev, unsigned int dac_data, intspin_unlock_irqrestore (&lchip->lock, flags); } +EXPORT_SYMBOL (locomo_m62332_senddata);/* * Frontlight control */ -static struct locomo *locomo_chip_driver (struct locomo_dev *ldev); -void locomo_frontlight_set (struct locomo_dev *dev,int duty,int vr,int bpwf) {unsigned long flags;@@ -1182,11 +1185,13 @@ int locomo_driver_register(struct locomo_driver *driver) driver->drv.bus = &locomo_bus_type;return driver_register (&driver->drv); } +EXPORT_SYMBOL (locomo_driver_register);void locomo_driver_unregister (struct locomo_driver *driver) {driver_unregister (&driver->drv); } +EXPORT_SYMBOL (locomo_driver_unregister);static int __init locomo_init (void ) {@@ -1208,11 +1213,3 @@ module_exit(locomo_exit);MODULE_DESCRIPTION ("Sharp LoCoMo core driver" );MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("John Lenz <[email protected]>" ); - -EXPORT_SYMBOL (locomo_driver_register); -EXPORT_SYMBOL (locomo_driver_unregister); -EXPORT_SYMBOL (locomo_gpio_set_dir); -EXPORT_SYMBOL (locomo_gpio_read_level); -EXPORT_SYMBOL (locomo_gpio_read_output); -EXPORT_SYMBOL (locomo_gpio_write); -EXPORT_SYMBOL (locomo_m62332_senddata);
PATCH 1/1 locomo.c: CodingStyle cleanups
In reply to H Hartley SweetenQuoted 6 lines · H Hartley Sweeten
EXPORT* macros should follow immediately after the closing function brace line.
The prototype for
locomo_chip_driver()is not needed since the static (inline) function is located earlier in the file.
Quoted 6 lines
Signed-off-by H Hartley Sweeten <[email protected]>Cc John Lenz <[email protected]>---
I originally sent this to the wrong list...
Ok. I guess as there isn't a specific sa11x0 maintainer, it might as well go to the patch system direct. (and might as well drop John's CC)