Fix fn-key release events for Samsung Q320 laptop
PATCH 1/1 Fix fn-key release events for Samsung Q320 laptop
This adds a workaround for the missing fn-key release events on Samsung Q320 and similar laptops.
Tested extensively on my own laptop.
--- drivers/input/keyboard/atkbd.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/input/keyboard/atkbd.c +9 -0
@@ -1630,6 +1630,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = { .driver_data = atkbd_samsung_forced_release_keys, }, { + .ident = "Samsung Q320/P320", + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"SAMSUNG ELECTRONICS CO., LTD." ), + DMI_MATCH(DMI_PRODUCT_NAME, "Q320/P320"), + }, + .callback = atkbd_setup_forced_release, + .driver_data = atkbd_samsung_forced_release_keys, + }, + { .ident ="Samsung SQ45S70S" , .matches = { DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
Signature · 1 line
1.6.4.1
Quoted 15 lines · Nick Gasson
This adds a workaround for the missing fn-key release events on Samsung Q320 and similar laptops.
Tested extensively on my own laptop.
Signed-off-by Nick Gasson <[email protected]>--- drivers/input/keyboard/atkbd.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)drivers/input/keyboard/atkbd.c +0
-0
drivers/input/keyboard/atkbd.c static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = { · line 1635
Quoted 6 lines
drivers/input/keyboard/atkbd.c +3
-0@@ -1630,6 +1630,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = { .driver_data = atkbd_samsung_forced_release_keys, }, { + .ident = "Samsung Q320/P320", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
Your patch is whitespace damaged .. All the tabs have been removed from your code, and the context code in the patch. That usually means the patch can't be applied .. It can happen when you X copy&paste the patch into an email. I'd use git-format-patch and git-send-email (since your using git anyway..)
Daniel
Dmitry Torokhov
maintainerHi Nick,
Quoted 6 lines · Nick Gasson
This adds a workaround for the missing fn-key release events on Samsung Q320 and similar laptops.
Tested extensively on my own laptop.
Signed-off-by Nick Gasson <[email protected]>
Thank you very much for your patch, hovewer I will not be accepting any more patches for the force release quirk in the kernel. 2.6.32 will have 'force_release' sysfs attribute allowing to apply the quirk from userspace.
Signature · 1 line
Dmitry