Skip to contentSkip to conversation

vxworks: Make loading vxworks less verbose

PATCH New Niklaus Giger 3 participants 4 messages Sep 23, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vxworks: Make loading vxworks less verbose

Newer vxWorks 6.x images have over 20 different C++ segments. This fills up the output with rarely used information.

---
 common/cmd_elf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
common/cmd_elf.c +2 -0
index 63f6fe7..bf7dd63 100644
@@ -286,6 +286,7 @@ unsigned long load_elf_image (unsigned long addr)
 			continue;
 		}
 
+#ifdef DEBUG
 		if (strtab) {
 			debug("%sing %s @ 0x%08lx (%ld bytes)\n",
 				(shdr->sh_type == SHT_NOBITS) ?
@@ -294,6 +295,7 @@ unsigned long load_elf_image (unsigned long addr)
 				(unsigned long) shdr->sh_addr,
 				(long) shdr->sh_size);
 		}
+#endif
 
 		if (shdr->sh_type == SHT_NOBITS) {
 			memset ((void *)shdr->sh_addr, 0, shdr->sh_size);
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 vxworks: Make loading vxworks less verbose

Please ignore this patch. Came in by mistake. Functionality already merged by commit 3c972849f2becbf19c13a24f090d293f37ecf616.

Sorry for the noise.

Best regards

Niklaus

#2 lore raw

PATCH 1/1 vxworks: Make loading vxworks less verbose

Quoted 5 lines · Niklaus Giger

Please ignore this patch. Came in by mistake. Functionality already merged by commit 3c972849f2becbf19c13a24f090d293f37ecf616.

Sorry for the noise.

Please ignore my response too :)
Tom

Quoted 7 lines

Best regards

Niklaus
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw

PATCH 1/1 vxworks: Make loading vxworks less verbose

In reply to Niklaus Giger
Quoted 21 lines · Niklaus Giger

Newer vxWorks 6.x images have over 20 different C++ segments. This fills up the output with rarely used information.

---
 common/cmd_elf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
common/cmd_elf.c +1 -0
index 63f6fe7..bf7dd63 100644
@@ -286,6 +286,7 @@ unsigned long load_elf_image (unsigned long addr)
 			continue;
 		}
 
+#ifdef DEBUG
 		if (strtab) {
 			debug("%sing %s @ 0x%08lx (%ld bytes)\n",
 				(shdr->sh_type == SHT_NOBITS) ?

common/cmd_elf.c unsigned long load_elf_image (unsigned long addr) · line 298

Quoted 4 lines
common/cmd_elf.c +1 -0
@@ -294,6 +295,7 @@ unsigned long load_elf_image (unsigned long addr)
 				(unsigned long) shdr->sh_addr,
 				(long) shdr->sh_size);
 		}
+#endif

I am not sure this will do anything.
From the decl of 'debug'

#ifdef DEBUG
#define debug(fmt,args...) printf (fmt ,##args)
#define debugX(level,fmt,args...) if (DEBUG>=level) printf(fmt,##args); #else
#define debug(fmt,args...)
#define debugX(level,fmt,args...)
#endif /* DEBUG */

debug is already hidden by the DEBUG define.

Maybe a better choice would be to switch to debugX

Tom

Quoted 3 lines
common/cmd_elf.c +0 -0
 		if (shdr->sh_type == SHT_NOBITS) {
 			memset ((void *)shdr->sh_addr, 0, shdr->sh_size);