gitweb atom feeds broken (on repo.or.cz only?)

hello git list, hello petr!

i noticed that the atom feeds generated by repo.or.cz's gitweb (e.g. [1]) show no content in firefox 3.5.2. this seems to be due to invalid xml in it as shown by running [1] through feedvalidator, results at [2].

their rss neighbors seemed not to be affected where i looked.
a fix would be cool still, as the atom feeds contain more detailed content.

sorry for the noise in case repo.or.cz runs customized atom generation.

sebastian

[1] http://repo.or.cz/w/dottout.git?a=atom
[2]
http://feedvalidator.org/check.cgi?url=http%3A%2F%2Frepo.or.cz%2Fw%2Fdottout.git%3Fa%3Datom

Hi,

it's a case of a misspelled tag. In the <author> tag <B> is closed by a </b>.

Cheers,
Ray Chuan

It's actually a bit more, I just checked against the Relax NG schema of Atom v11 from RFC 4287.

Neither <span> nor <b>/<B> are allowed inside <name>, and the '\n' isn't either. This is what we get:

=============================================================================
<author><name>&#x61;&#x6E;drea<!-- @ -->&#64;dot&#x74;out<span><B>&#46;</b></span>com</name></author>\n<icon>/git-favicon.png</icon>
=============================================================================

This would be valid:

=============================================================================
<author>
<name>and&#x72;ea<!-- @ -->&#64;&#x64;ottout&#46;com</name>
</author>
<icon>/git-favicon.png</icon>
=============================================================================

Petr, is the e-mail crippling a repo.or.cz-only thing?

Sebastian

Petr, any news on this one?

I just check and it still seems broken.

Sebastian

Fixed, it's a HTML::Email::Obfuscate bug.

				Petr "Pasky" Baudis
A lot of people have my books on their bookshelves.
That's the problem, they need to read them. -- Don Knuth

Though the feed works in Firefox now I wouldn't call it fixed, yet,

As I elaborated earlier in this thread the Atom you generate is not valid. I cannot put it better than feedvalidator:

http://feedvalidator.org/check.cgi?url=http%3A%2F%2Frepo.or.cz%2Fw%2Fdottout.git%3Fa%3Datom

Please fix that, too.

Sebastian

I'm sorry, I don't have time for fixing that. Feel free to send me a patch.

Kind regards,

				Petr "Pasky" Baudis
A lot of people have my books on their bookshelves.
That's the problem, they need to read them. -- Don Knuth