Skip to contentSkip to conversation

Fix session initialization when following referrals

PATCH Benny Halevy 1 participant 1 message Sep 29, 2009 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): alpine.OSX.2.00.0909291327360.21014-uDfGT2BMUji44ywRPIzf9A@public.gmane.org

#2 lore raw
Quoted 9 lines · Jjgod Jiang

Hi,

When following NFSv4 referrals, nfs will initialize the session of the client with nfs4_alloc_session() and expecting to recover the session on SEQUENCE operation. However, nfs41_setup_sequence() expects the fc_slot_table->highest_used_slotid of this session to be -1, otherwise it will simply return -EAGAIN without recovering the session. This patch complete nfs4_alloc_session() so that nfs41_setup_sequence() can successfully return when following referrals.

Ack.

I'll merge this patch also in my tree for the upcoming Bakeathon.

Benny

P.S. please use [email protected] rather than [email protected]

Quoted 18 lines
nfs4proc.c +1 -1
@@ -4789,6 +4789,7 @@ struct nfs4_session *nfs4_alloc_session(
  	clp->cl_cons_state = NFS_CS_SESSION_INITING;
 
  	tbl = &session->fc_slot_table;
+	tbl->highest_used_slotid = -1;
  	spin_lock_init(&tbl->slot_tbl_lock);
  	rpc_init_wait_queue(&tbl->slot_tbl_waitq, "ForeChannel Slot table");
 
 
------------------------------------------------------------------------

_______________________________________________
pNFS mailing list
[email protected]
http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs