acerhdf: Limit modalias matching to supported boards
PATCH 1/1 acerhdf: Limit modalias matching to supported boards
We got reports of acerhdf issuing warnings on Acer laptops other than Aspire Ones. Looking at the dmi match this sounds a bit to generic. IOW the module gets loaded on any Acer laptop. After the following patch the module gets still loaded on my Aspire One but not on the reported other laptop. The same change might be helpful for the other two dmi matches, but I had no way of testing.
-Stefan
Quoted 1 line
From
389f61f7e66ce615dc6418cb856e167edaa74b42Mon Sep 17 00:00:00 2001
From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boards
The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA. Probably the same change should be made for the two other entries.
--- drivers/platform/x86/acerhdf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/platform/x86/acerhdf.c +1 -1
@@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Peter Feuerer" );MODULE_DESCRIPTION ("Aspire One temperature and fan driver" ); -MODULE_ALIAS ("dmi:*:*Acer*:*:" ); +MODULE_ALIAS ("dmi:*:*Acer*:pnAOA*:" );MODULE_ALIAS ("dmi:*:*Gateway*:*:" );MODULE_ALIAS ("dmi:*:*Packard Bell*:*:" );
Signature · 1 line
1.5.4.5
Quoted 7 lines · Stefan Bader
We got reports of acerhdf issuing warnings on Acer laptops other than Aspire Ones. Looking at the dmi match this sounds a bit to generic. IOW the module gets loaded on any Acer laptop. After the following patch the module gets still loaded on my Aspire One but not on the reported other laptop.
The same change might be helpful for the other two dmi matches, but I had no way of testing.
Yeah, we might need someone with such a machine to give us /sys/class/dmi/id/modalias content. Peter, do you have any users with such machines?
Quoted 7 lines
From
389f61f7e66ce615dc6418cb856e167edaa74b42Mon Sep 17 00:00:00 2001
From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boards
Quoted 8 lines
The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA. Probably the same change should be made for the two other entries.Signed-off-by Stefan Bader <[email protected]>
Quoted 20 lines
--- drivers/platform/x86/acerhdf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/platform/x86/acerhdf.c +1
-1@@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Peter Feuerer" );MODULE_DESCRIPTION ("Aspire One temperature and fan driver" ); -MODULE_ALIAS ("dmi:*:*Acer*:*:" ); +MODULE_ALIAS ("dmi:*:*Acer*:pnAOA*:" );MODULE_ALIAS ("dmi:*:*Gateway*:*:" );MODULE_ALIAS ("dmi:*:*Packard Bell*:*:" );Signature · 1 line
1.5.4.5
Signature · 2 lines
Regards/Gruss,
Boris.Peter Feuerer
maintainerQuoted 9 lines · Borislav Petkov
Quoted 7 lines · Stefan Bader
We got reports of acerhdf issuing warnings on Acer laptops other than Aspire Ones. Looking at the dmi match this sounds a bit to generic. IOW the module gets loaded on any Acer laptop. After the following patch the module gets still loaded on my Aspire One but not on the reported other laptop.
The same change might be helpful for the other two dmi matches, but I had no way of testing.
Quoted 3 lines
Yeah, we might need someone with such a machine to give us
/sys/class/dmi/id/modaliascontent. Peter, do you have any users with such machines?
I search my acerhdf-inbox for the people who sent me the BIOS versions, maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.
But, can't we simply assume, following dmi lines?
MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");
We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?
Quoted 36 lines
Quoted 8 lines
From
389f61f7e66ce615dc6418cb856e167edaa74b42Mon Sep 17 00:00:00 2001
From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boardsQuoted 8 lines
The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA. Probably the same change should be made for the two other entries.Signed-off-by Stefan Bader <[email protected]>Acked-by Borislav Petkov <[email protected]>Quoted 17 lines
--- drivers/platform/x86/acerhdf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/platform/x86/acerhdf.c +1
-1@@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Peter Feuerer" );MODULE_DESCRIPTION ("Aspire One temperature and fan driver" ); -MODULE_ALIAS ("dmi:*:*Acer*:*:" ); +MODULE_ALIAS ("dmi:*:*Acer*:pnAOA*:" );MODULE_ALIAS ("dmi:*:*Gateway*:*:" );MODULE_ALIAS ("dmi:*:*Packard Bell*:*:" );
Quoted 2 lines
Quoted 2 lines
Signature · 1 line
1.5.4.5
kind regards,
--peter
Quoted 17 lines · Peter Feuerer
Quoted 9 lines · Borislav Petkov
Quoted 7 lines · Stefan Bader
We got reports of acerhdf issuing warnings on Acer laptops other than Aspire Ones. Looking at the dmi match this sounds a bit to generic. IOW the module gets loaded on any Acer laptop. After the following patch the module gets still loaded on my Aspire One but not on the reported other laptop.
The same change might be helpful for the other two dmi matches, but I had no way of testing.Quoted 3 lines
Yeah, we might need someone with such a machine to give us
/sys/class/dmi/id/modaliascontent. Peter, do you have any users with such machines?I search my acerhdf-inbox for the people who sent me the BIOS versions, maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.
Quoted 8 lines
But, can't we simply assume, following dmi lines?
MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?
Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.
-Stefan
Quoted 41 lines
Quoted 36 lines
Quoted 8 lines
From
389f61f7e66ce615dc6418cb856e167edaa74b42Mon Sep 17 00:00:00 2001
From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: acerhdf: Limit modalias matching to supported boardsQuoted 8 lines
The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA. Probably the same change should be made for the two other entries.Signed-off-by Stefan Bader <[email protected]>Acked-by Borislav Petkov <[email protected]>Quoted 17 lines
--- drivers/platform/x86/acerhdf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/platform/x86/acerhdf.c +1
-1@@ -629,7 +629,7 @@ static void __exit acerhdf_exit(void)MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Peter Feuerer" );MODULE_DESCRIPTION ("Aspire One temperature and fan driver" ); -MODULE_ALIAS ("dmi:*:*Acer*:*:" ); +MODULE_ALIAS ("dmi:*:*Acer*:pnAOA*:" );MODULE_ALIAS ("dmi:*:*Gateway*:*:" );MODULE_ALIAS ("dmi:*:*Packard Bell*:*:" );Quoted 2 lines
Quoted 2 lines
Signature · 1 line
1.5.4.5kind regards,
--peter
Signature · 1 line
When all other means of communication fail, try words!
Quoted 1 line
From
60cdb7bea856fdd594262ee1e9608cd2210cf196Mon Sep 17 00:00:00 2001
From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards
The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA or DOA for Packard Bell.
--- drivers/platform/x86/acerhdf.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/acerhdf.c +4 -3
@@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)MODULE_LICENSE ("GPL" );MODULE_AUTHOR ("Peter Feuerer" );MODULE_DESCRIPTION ("Aspire One temperature and fan driver" ); -MODULE_ALIAS ("dmi:*:*Acer*:*:" ); -MODULE_ALIAS ("dmi:*:*Gateway*:*:" ); -MODULE_ALIAS ("dmi:*:*Packard Bell*:*:" ); +MODULE_ALIAS ("dmi:*:*Acer*:pnAOA*:" ); +MODULE_ALIAS ("dmi:*:*Gateway*:pnAOA*:" ); +MODULE_ALIAS ("dmi:*:*Packard Bell*:pnAOA*:" ); +MODULE_ALIAS ("dmi:*:*Packard Bell*:pnDOA*:" );module_init (acerhdf_init);module_exit (acerhdf_exit);
Signature · 1 line
1.5.4.3
Quoted 17 lines · Stefan Bader
Quoted 11 lines
Quoted 1 line
I search my acerhdf-inbox for the people who sent me the BIOS versions,
maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.
But, can't we simply assume, following dmi lines?
MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");Quoted 5 lines
We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?
Quoted 3 lines
Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.
Well, acerhdf.c and dmi-id.c both do dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.
IMO, we should just go ahead send it to Len. Stefan, you have my ACK.
Signature · 2 lines
Regards/Gruss, Boris
Peter Feuerer
maintainerQuoted 22 lines · Borislav Petkov
Quoted 17 lines · Stefan Bader
Quoted 11 lines
Quoted 1 line
I search my acerhdf-inbox for the people who sent me the BIOS versions,
maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.
But, can't we simply assume, following dmi lines?
MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");Quoted 5 lines
We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?
Quoted 3 lines
Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.
Quoted 6 lines
Well,
acerhdf.canddmi-id.cboth dodmi_get_system_info(DMI_PRODUCT_NAME)when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.IMO, we should just go ahead send it to Len. Stefan, you have my ACK.
Will try the patch tomorrow morning and you'll then get also my ack, if it's working.
--peter
Quoted 29 lines · Peter Feuerer
Quoted 27 lines · Borislav Petkov
Quoted 17 lines · Stefan Bader
Quoted 11 lines
Quoted 1 line
I search my acerhdf-inbox for the people who sent me the BIOS versions,
maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.
But, can't we simply assume, following dmi lines?
MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");Quoted 5 lines
We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?
Quoted 3 lines
Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.
Well,
acerhdf.canddmi-id.cboth dodmi_get_system_info(DMI_PRODUCT_NAME)when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.
Quoted 5 lines
Quoted 1 line
IMO, we should just go ahead send it to Len. Stefan, you have my ACK.
Will try the patch tomorrow morning and you'll then get also my ack, if it's working.
--peter
Ok, cool. Will wait on that.
-Stefan
Signature · 1 line
When all other means of communication fail, try words!
Quoted 25 lines · Stefan Bader
Quoted 24 lines · Peter Feuerer
Quoted 22 lines · Borislav Petkov
Quoted 20 lines · Stefan Bader
Quoted 11 lines
Quoted 1 line
I search my acerhdf-inbox for the people who sent me the BIOS versions,
maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.
But, can't we simply assume, following dmi lines?
MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");Quoted 5 lines
We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?
Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Well,
acerhdf.canddmi-id.cboth dodmi_get_system_info(DMI_PRODUCT_NAME)when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.IMO, we should just go ahead send it to Len. Stefan, you have my ACK.
Thank you Stefan!
regards,
--peter