drm: make sure page protections are updated after changing vm_flags.
Subsystems (2)
PATCH 1/1 drm: make sure page protections are updated after changing vm_flags.
Some architectures compute ->vm_page_prot depending on ->vm_flags, so we need to update the protections after adjusting the flags.
drivers/gpu/drm/drm_gem.c +1 -1
@@ -537,7 +537,7 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) vma->vm_ops = obj->dev->driver->gem_vm_ops; vma->vm_private_data = map->handle;/* FIXME: use pgprot_writecombine when available */ - vma->vm_page_prot =pgprot_writecombine (vma->vm_page_prot); + vma->vm_page_prot =pgprot_writecombine (vm_get_page_prot (vma->vm_flags));/* Take a ref for this mapping of the object, so that the fault * handler can dereference the mmap offset's pointer to the object.
Quoted 11 lines · On Wed, 30 Sep 2009 15:55:39 -0700 Jeremy Fitzhardinge <[email protected]> wrote:
Some architectures compute ->vm_page_prot depending on ->vm_flags, so we need to update the protections after adjusting the flags.
Reported-by Jan Beulich <[email protected]>Signed-off-by Jeremy Fitzhardinge <[email protected]>drivers/gpu/drm/drm_gem.c +0
-0
drivers/gpu/drm/drm_gem.c int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) · line 543
Quoted 8 lines
drivers/gpu/drm/drm_gem.c +1
-1@@ -537,7 +537,7 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) vma->vm_ops = obj->dev->driver->gem_vm_ops; vma->vm_private_data = map->handle;/* FIXME: use pgprot_writecombine when available */ - vma->vm_page_prot =pgprot_writecombine (vma->vm_page_prot); + vma->vm_page_prot =pgprot_writecombine (vm_get_page_prot (vma->vm_flags));/* Take a ref for this mapping of the object, so that the fault * handler can dereference the mmap offset's pointer to the object.
u fail changelogology.
What were the consequences of the bug which you just fixed?
Quoted 21 lines · Andrew Morton
Quoted 17 lines · On Wed, 30 Sep 2009 15:55:39 -0700 Jeremy Fitzhardinge <[email protected]> wrote:
Some architectures compute ->vm_page_prot depending on ->vm_flags, so we need to update the protections after adjusting the flags.
Reported-by Jan Beulich <[email protected]>Signed-off-by Jeremy Fitzhardinge <[email protected]>drivers/gpu/drm/drm_gem.c +1
-1@@ -537,7 +537,7 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) vma->vm_ops = obj->dev->driver->gem_vm_ops; vma->vm_private_data = map->handle;/* FIXME: use pgprot_writecombine when available */ - vma->vm_page_prot =pgprot_writecombine (vma->vm_page_prot); + vma->vm_page_prot =pgprot_writecombine (vm_get_page_prot (vma->vm_flags));
Quoted 7 lines
drivers/gpu/drm/drm_gem.c int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma) · line 543
Quoted 3 lines
drivers/gpu/drm/drm_gem.c +0
-0/* Take a ref for this mapping of the object, so that the fault * handler can dereference the mmap offset's pointer to the object. u fail changelogology.
What were the consequences of the bug which you just fixed?
AFAIK this only affects running X under Xen; without this patch you get lots of coloured blobs on the screen, or maybe a complete lockup. Or anything really.
But that still depends on lots of out-of-tree stuff, so I don't think there are any consequences for anyone else. But it is wrong in principle.
J