Skip to contentSkip to conversation

mlx4_en: performing CLOSE_PORT at the end of tear-down process

PATCH In review Yevgeny Petrilin 1 participant 1 message Oct 1, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 6/7 mlx4_en: performing CLOSE_PORT at the end of tear-down process

As required by ConnectX PRM.
Not doing it might cause races in the HW during tear down process.

---
 drivers/net/mlx4/en_netdev.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/mlx4/en_netdev.c +4 -2
index 13fc6f0..b1e80d8 100644
@@ -711,9 +711,8 @@ void mlx4_en_stop_port(struct net_device *dev)
 	netif_tx_stop_all_queues(dev);
 	netif_tx_unlock_bh(dev);
 
-	/* close port*/
+	/* Set port as not active */
 	priv->port_up = false;
-	mlx4_CLOSE_PORT(mdev->dev, priv->port);
 
 	/* Unregister Mac address for the port */
 	mlx4_unregister_mac(mdev->dev, priv->port, priv->mac_index);
@@ -738,6 +737,9 @@ void mlx4_en_stop_port(struct net_device *dev)
 			msleep(1);
 		mlx4_en_deactivate_cq(priv, &priv->rx_cq[i]);
 	}
+
+	/* close port*/
+	mlx4_CLOSE_PORT(mdev->dev, priv->port);
 }
 
 static void mlx4_en_restart(struct work_struct *work)
Signature · 1 line
1.6.1.3