Skip to contentSkip to conversation

tg3: Remove prev_vlan_tag from struct tx_ring_info

PATCH Applied Eric Dumazet 3 participants 4 messages Sep 30, 2009 – Oct 2, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Eric Dumazet

author
#0 lore raw

PATCH 1/1 tg3: Remove prev_vlan_tag from struct tx_ring_info

prev_vlan_tag field is not used.

Patch saves 512*8 bytes per tx queue ring on 64bit arches.

Signed-off-by Eric Dumazet <[email protected]>

---

drivers/net/tg3.h +0 -1
index 82b45d8..524691c 100644
@@ -2412,7 +2412,6 @@ struct ring_info {
 
 struct tx_ring_info {
 	struct sk_buff                  *skb;
-	u32                             prev_vlan_tag;
 };
 
 struct tg3_config_info {
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Eric Dumazet

prev_vlan_tag field is not used.

Patch saves 512*8 bytes per tx queue ring on 64bit arches.

Signed-off-by Eric Dumazet <[email protected]>

Looks good to me.

Acked-by Matthew Carlson <[email protected]>
Quoted 15 lines

---

drivers/net/tg3.h +0 -1
index 82b45d8..524691c 100644
@@ -2412,7 +2412,6 @@ struct ring_info {
 
 struct tx_ring_info {
 	struct sk_buff                  *skb;
-	u32                             prev_vlan_tag;
 };
 
 struct tg3_config_info {
maintainer Applied
#2 lore raw

From: "Matt Carlson" <[email protected]>
Date: Wed, 30 Sep 2009 10:26:43 -0700

Quoted 10 lines · Eric Dumazet
Quoted 5 lines

prev_vlan_tag field is not used.

Patch saves 512*8 bytes per tx queue ring on 64bit arches.

Signed-off-by Eric Dumazet <[email protected]>

Looks good to me.

Acked-by Matthew Carlson <[email protected]>

Applied, thanks.

Eric, I had to apply this by hand because:

Quoted 6 lines

drivers/net/tg3.h struct ring_info { · line 2415

Quoted 6 lines
drivers/net/tg3.h +0 -1
@@ -2412,7 +2412,6 @@ struct ring_info {
 
 struct tx_ring_info {
 	struct sk_buff                  *skb;
-	u32                             prev_vlan_tag;
 };

Your email client changed tabs into spaces.

author
#3 lore raw
Quoted 5 lines · David Miller

Applied, thanks.

Eric, I had to apply this by hand because:

Quoted 8 lines
Quoted 6 lines

drivers/net/tg3.h struct ring_info { · line 2415

Quoted 6 lines
drivers/net/tg3.h +0 -1
@@ -2412,7 +2412,6 @@ struct ring_info {
 
 struct tx_ring_info {
 	struct sk_buff                  *skb;
-	u32                             prev_vlan_tag;
 };

Your email client changed tabs into spaces.

Oops, I'm sorry Dave, I did a copy/paste and forgot about tabs.

Thanks