Skip to contentSkip to conversation

omap_hsmmc: Add missing probe handler hook to platform driver data

PATCH Superseded Roger Quadros 2 participants 3 messages Oct 1, 2009 – Oct 2, 2009 1 message not in the archive

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap_hsmmc: Add missing probe handler hook to platform driver data

The missing probe handler hook will never probe the driver. Add it back. Fixes broken MMC on OMAP.

---
 drivers/mmc/host/omap_hsmmc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/host/omap_hsmmc.c +1 -0
index 4487cc0..26abe1e 100644
@@ -2001,6 +2001,7 @@ clk_en_err:
 #endif
 
 static struct platform_driver omap_hsmmc_driver = {
+	.probe		= omap_hsmmc_probe,
 	.remove		= omap_hsmmc_remove,
 	.suspend	= omap_hsmmc_suspend,
 	.resume		= omap_hsmmc_resume,
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 omap_hsmmc: Add missing probe handler hook to platform

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes-testing

Initial commit ID (Likely to change): ff50faceca4c78184af7087e2368a5c869688755

PatchWorks
http://patchwork.kernel.org/patch/50970/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=ff50faceca4c78184af7087e2368a5c869688755

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 14 lines · ext Rok Markovič

This is not the correct way to do it. There was some conflict during merge in init function. Correct patch should look like this:

drivers/mmc/host/omap_hsmmc.c +1 -1
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
 static int __init omap_hsmmc_init(void)
 {
        /* Register the MMC driver */
-       return platform_driver_register(&omap_hsmmc_driver);
+       return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
 }
 
 static void __exit omap_hsmmc_cleanup(void)
Quoted 2 lines

Rok

Oh yes. Since omap_hsmmc is not a hot-pluggable device. Will send a v2.

Thanks Rok, for pointing this out.

Quoted 18 lines

Dne četrtek 1. oktobra 2009 ob 16:39:13 ste napisali:

Quoted 15 lines

The missing probe handler hook will never probe the driver. Add it back. Fixes broken MMC on OMAP.

---
 drivers/mmc/host/omap_hsmmc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/host/omap_hsmmc.c +0 -0
index 4487cc0..26abe1e 100644
@@ -2001,6 +2001,7 @@ clk_en_err:
 #endif
 
Quoted 6 lines

drivers/mmc/host/omap_hsmmc.c clk_en_err: · line 2007

Quoted 6 lines
drivers/mmc/host/omap_hsmmc.c +1 -0
 static struct platform_driver omap_hsmmc_driver = {
+	.probe		= omap_hsmmc_probe,
 	.remove		= omap_hsmmc_remove,
 	.suspend	= omap_hsmmc_suspend,
 	.resume		= omap_hsmmc_resume,

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html