Skip to contentSkip to conversation

commit 68e5e9d734503695915734e50e9427624cf8f3b2 (Re: vfb: make virtual framebuffer mmapable)

DISCUSSION Jan Beulich 2 participants 2 messages Oct 2, 2009

lore
Share & tools
lore
#0 lore raw

Is there any particular reason why this change uses vmalloc_32() rather than simply vmalloc()? I can't see why the underlying physical address width would matter here in any way...

Thanks, Jan

#1 lore raw

Hi Jan,

Quoted 2 lines · Jan Beulich

Is there any particular reason why this change uses vmalloc_32() rather than simply vmalloc()?

I don't think so. I wasn't very experienced with kernel programming that time and just copied code from another driver. Actually I think we don't really need all this rvmalloc()/rvfree() magic we just need to use remap_vmalloc_range() instead of remap_pfn_range().

Regards, Ilya.