Skip to contentSkip to conversation

s3c2440: mini2440 buildfix

PATCH New Anand Gadiyar 3 participants 3 messages Oct 1, 2009 – Oct 2, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s3c2440: mini2440 buildfix

s3c2440: mini2440 buildfix

Fix the following two build errors seen with mini2440_defconfig:

CC arch/arm/plat-s3c24xx/cpu.o
arch/arm/plat-s3c24xx/cpu.c:84: error: 's3c2410a_init' undeclared here (not in a function) make[1]: *** [arch/arm/plat-s3c24xx/cpu.o] Error 1
make: *** [arch/arm/plat-s3c24xx] Error 2

LD .tmp_vmlinux1
arch/arm/mach-s3c2440/built-in.o:(.init.data+0x724): undefined reference to `s3c_device_usb'
make: *** [.tmp_vmlinux1] Error 1

CC Gaye Abdoulaye Walsimou <[email protected]>
CC Ben Dooks <[email protected]>

---
The latter error was reported by Gaye Abdoulaye Walsimou. I hit the former error while attempting to fix it.

I don't have this board, so I do not know if this is correct. Build-tested only.

- Anand

arch/arm/mach-s3c2440/Kconfig +1 -0
index d7bba91..64f9e6d 100644
@@ -102,6 +102,7 @@ config MACH_MINI2440
 	select EEPROM_AT24
 	select LEDS_TRIGGER_BACKLIGHT
 	select SND_S3C24XX_SOC_S3C24XX_UDA134X
+	select S3C_DEV_USB_HOST
 	select S3C_DEV_NAND
 	help
 	  Say Y here to select support for the MINI2440. Is a 10cm x 10cm board
arch/arm/plat-s3c24xx/include/plat/s3c2410.h +1 -0
index b6deeef..82ab4aa 100644
@@ -27,6 +27,7 @@ extern void s3c2410_init_clocks(int xtal);
 #define s3c2410_init_uarts NULL
 #define s3c2410_map_io NULL
 #define s3c2410_init NULL
+#define s3c2410a_init NULL
 #endif
 
 extern int s3c2410_baseclk_add(void);
#1 lore raw

PATCH 1/1 s3c2440: mini2440 buildfix

Quoted 30 lines · Anand Gadiyar

s3c2440: mini2440 buildfix

Fix the following two build errors seen with mini2440_defconfig:

CC arch/arm/plat-s3c24xx/cpu.o
arch/arm/plat-s3c24xx/cpu.c:84: error: 's3c2410a_init' undeclared here (not in a function) make[1]: *** [arch/arm/plat-s3c24xx/cpu.o] Error 1
make: *** [arch/arm/plat-s3c24xx] Error 2

LD .tmp_vmlinux1
arch/arm/mach-s3c2440/built-in.o:(.init.data+0x724): undefined reference to `s3c_device_usb'
make: *** [.tmp_vmlinux1] Error 1

CC Gaye Abdoulaye Walsimou <[email protected]>
CC Ben Dooks <[email protected]>

---
The latter error was reported by Gaye Abdoulaye Walsimou. I hit the former error while attempting to fix it.

I don't have this board, so I do not know if this is correct. Build-tested only.

- Anand

arch/arm/mach-s3c2440/Kconfig +0 -0
index d7bba91..64f9e6d 100644

arch/arm/mach-s3c2440/Kconfig config MACH_MINI2440 · line 108

Quoted 7 lines
arch/arm/mach-s3c2440/Kconfig +1 -0
@@ -102,6 +102,7 @@ config MACH_MINI2440
 	select EEPROM_AT24
 	select LEDS_TRIGGER_BACKLIGHT
 	select SND_S3C24XX_SOC_S3C24XX_UDA134X
+	select S3C_DEV_USB_HOST
 	select S3C_DEV_NAND
 	help
 	  Say Y here to select support for the MINI2440. Is a 10cm x 10cm board

Yes, this is the fix for this one.

arch/arm/plat-s3c24xx/include/plat/s3c2410.h extern void s3c2410_init_clocks(int xtal); · line 31

Quoted 10 lines
arch/arm/plat-s3c24xx/include/plat/s3c2410.h +1 -0
index b6deeef..82ab4aa 100644
@@ -27,6 +27,7 @@ extern void s3c2410_init_clocks(int xtal);
 #define s3c2410_init_uarts NULL
 #define s3c2410_map_io NULL
 #define s3c2410_init NULL
+#define s3c2410a_init NULL
 #endif

this one we've already got a fix queued, awaiting feedback on the s3c64xx fixes before pushing upstream.

Signature · 4 lines
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/1 s3c2440: mini2440 buildfix

Quoted 44 lines · Ben Dooks
Quoted 31 lines · Anand Gadiyar

s3c2440: mini2440 buildfix

Fix the following two build errors seen with mini2440_defconfig:

CC arch/arm/plat-s3c24xx/cpu.o
arch/arm/plat-s3c24xx/cpu.c:84: error: 's3c2410a_init' undeclared here (not in a function) make[1]: *** [arch/arm/plat-s3c24xx/cpu.o] Error 1
make: *** [arch/arm/plat-s3c24xx] Error 2

LD .tmp_vmlinux1
arch/arm/mach-s3c2440/built-in.o:(.init.data+0x724): undefined reference to `s3c_device_usb'
make: *** [.tmp_vmlinux1] Error 1

CC Gaye Abdoulaye Walsimou <[email protected]>
CC Ben Dooks <[email protected]>

---
The latter error was reported by Gaye Abdoulaye Walsimou. I hit the former error while attempting to fix it.

I don't have this board, so I do not know if this is correct. Build-tested only.

- Anand

arch/arm/mach-s3c2440/Kconfig +0 -0
index d7bba91..64f9e6d 100644

arch/arm/mach-s3c2440/Kconfig config MACH_MINI2440 · line 108

Quoted 7 lines
arch/arm/mach-s3c2440/Kconfig +1 -0
@@ -102,6 +102,7 @@ config MACH_MINI2440
 	select EEPROM_AT24
 	select LEDS_TRIGGER_BACKLIGHT
 	select SND_S3C24XX_SOC_S3C24XX_UDA134X
+	select S3C_DEV_USB_HOST
 	select S3C_DEV_NAND
 	help
 	  Say Y here to select support for the MINI2440. Is a 10cm x 10cm board

Yes, this is the fix for this one.

Quoted 16 lines

arch/arm/plat-s3c24xx/include/plat/s3c2410.h extern void s3c2410_init_clocks(int xtal); · line 32

Quoted 11 lines
arch/arm/plat-s3c24xx/include/plat/s3c2410.h +1 -0
index b6deeef..82ab4aa 100644
@@ -27,6 +27,7 @@ extern void s3c2410_init_clocks(int xtal);
 #define s3c2410_init_uarts NULL
 #define s3c2410_map_io NULL
 #define s3c2410_init NULL
+#define s3c2410a_init NULL
 #endif
 

this one we've already got a fix queued, awaiting feedback on the s3c64xx fixes before pushing upstream.

Thanks for these fix!
I didn't notice the second one, but I've already submitted similar patch for the first!

Regards,